Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Galaxy roles should be prefixed with organisation #242

Open
manics opened this issue Jan 13, 2017 · 4 comments
Open

Galaxy roles should be prefixed with organisation #242

manics opened this issue Jan 13, 2017 · 4 comments

Comments

@manics
Copy link
Member

manics commented Jan 13, 2017

The dependencies of galaxy roles have the form openmicroscopy.basedeps, however the playbooks in this repository expect a role name without a prefix (just basedeps). As a result some roles are installed twice, with and without the prefix.

Proposed fix: all playbooks using Galaxy roles should use the prefix.

@joshmoore
Copy link
Member

What are the alternatives? e.g. using name: aggressively to not have duplicates?

- src: openmicroscopy.basedeps
  version: ...
  name: basedeps

Questions that this raises for me:

  • will users want to overwrite with updating playbooks (i.e. swap to someuser.basedeps in requirements.yml`)
  • if we use openmicroscopy.basedeps everywhere, should we also prefix the variable names further?

@manics
Copy link
Member Author

manics commented Jan 16, 2017

What are the alternatives? e.g. using name: aggressively to not have duplicates?

That might work, but most galaxy roles/examples seem to use PREFIX. in playbooks.

will users want to overwrite with updating playbooks (i.e. swap to someuser.basedeps in requirements.yml`)

Do you mean always use the prefix in playbooks?

if we use openmicroscopy.basedeps everywhere, should we also prefix the variable names further?

Don't know, other galaxy roles that I've looked at don't, and chances are if you're running two roles with the same name in the same playbook you're asking for trouble.

@joshmoore
Copy link
Member

Do you mean always use the prefix in playbooks?

No, that would point to not prefixing.

if you're running two roles with the same name in the same playbook you're asking for trouble.

Doesn't that also suggest not prefixing?

@manics
Copy link
Member Author

manics commented Jan 16, 2017

Doesn't that also suggest not prefixing?

That was in response to your comment about prefixing variables with the galaxy org. My proposal is to prefix the roles when they're d playbooks, but not the variables since I don't think you're likely to want to use two roles with the same name from different organisations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants