New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kymograph script & analysis_utils #1
Conversation
|
Support for permissions proposed in PR will-moore#1 |
@joshmoore @sbesson I'm still not happy about our solution for sharing 'util' code between scripts (using "analysis_utils.py" above - as discussed on https://trac.openmicroscopy.org.uk/ome/ticket/9368). This requires you to have dist/lib/scripts/ on your PYTHONPATH and it creates an invalid 'script' to appear in the client UIs. Although we can find workarounds for these, it makes it too inconvenient for admins to install these scripts. |
@will-moore, definitely still a problem. Concrete suggestion? |
My preference for now is to simply duplicate the code in the 2 scripts that need it. Until the scripting framework supports a "proper" solution, an alternative solution is more pain than having one method in two places. |
For the moment, that's probably the best we can do (unless we add a "scripts-common.git"). |
NB: Interestingly, I wonder if fs-lite provides a solution, in that scripts get uploaded to an importable directory. |
See the Kymograph.mov attached to that ticket for a demo of this functionality
@will-moore, can you accept @sbesson's pr now? |
@sbesson PR can't be merged automatically, No. |
- Populate the client message in the main processing function
@will-moore, can you recheck @sbesson's PR? |
Kymograph - permission tests. All seems to be working as expected - merging...
Script name and description fixed
Kymograph and Kymograph Analysis both worked as expected. The former took a long time but this was on an fslite imported image so may be an fslite performance issue. Plot Profile worked okay if I left the Channel blank but it gave an error if I entered a Channel (full exception available if needed): WARNING:omero.gateway:ApiUsageException on <class 'omero.gateway.OmeroGatewaySafeCallWrapper'> to 86:24:41:e3:-592b8985:13a208e041e:-614aomero.api.RawPixelsStore getTile((0, -1, 2, 275, 221, 11, 43), {}) |
This will be rebased onto dev_4_4 as a new branch |
Fix last flake8 warning
Run scripts with environment variables
Run scripts with environment variables
Demo movie on #8206.