Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kymograph script & analysis_utils #1

Closed
wants to merge 13 commits into from
Closed

Conversation

will-moore
Copy link
Member

Demo movie on #8206.

@jburel
Copy link
Member

jburel commented Sep 26, 2012

@will-moore:

  • add support for permissions
  • version need to be updated

@sbesson
Copy link
Member

sbesson commented Sep 26, 2012

Support for permissions proposed in PR will-moore#1

@will-moore
Copy link
Member Author

@joshmoore @sbesson I'm still not happy about our solution for sharing 'util' code between scripts (using "analysis_utils.py" above - as discussed on https://trac.openmicroscopy.org.uk/ome/ticket/9368). This requires you to have dist/lib/scripts/ on your PYTHONPATH and it creates an invalid 'script' to appear in the client UIs. Although we can find workarounds for these, it makes it too inconvenient for admins to install these scripts.

@joshmoore
Copy link
Member

@will-moore, definitely still a problem. Concrete suggestion?

@will-moore
Copy link
Member Author

My preference for now is to simply duplicate the code in the 2 scripts that need it. Until the scripting framework supports a "proper" solution, an alternative solution is more pain than having one method in two places.

@joshmoore
Copy link
Member

For the moment, that's probably the best we can do (unless we add a "scripts-common.git").

@joshmoore
Copy link
Member

NB: Interestingly, I wonder if fs-lite provides a solution, in that scripts get uploaded to an importable directory.

Will Moore added 2 commits September 26, 2012 13:40
See the Kymograph.mov attached to that ticket for a demo of this functionality
@joshmoore
Copy link
Member

@will-moore, can you accept @sbesson's pr now?

@will-moore
Copy link
Member Author

@sbesson PR can't be merged automatically, No.

@joshmoore
Copy link
Member

@will-moore, can you recheck @sbesson's PR?

Will Moore added 2 commits October 1, 2012 05:38
Kymograph - permission tests. All seems to be working as expected - merging...
@ximenesuk
Copy link
Contributor

Kymograph and Kymograph Analysis both worked as expected. The former took a long time but this was on an fslite imported image so may be an fslite performance issue. Plot Profile worked okay if I left the Channel blank but it gave an error if I entered a Channel (full exception available if needed):

WARNING:omero.gateway:ApiUsageException on <class 'omero.gateway.OmeroGatewaySafeCallWrapper'> to 86:24:41:e3:-592b8985:13a208e041e:-614aomero.api.RawPixelsStore getTile((0, -1, 2, 275, 221, 11, 43), {})
Traceback (most recent call last):
File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/python/omero/gateway/init.py", line 3324, in call
return self.f(_args, *_kwargs)
File "/home/omero/slave/workspace/OMERO-merge-green/src/dist/lib/python/omero_api_RawPixelsStore_ice.py", line 189, in getTile
return _M_omero.api.RawPixelsStore._op_getTile.invoke(self, ((z, c, t, x, y, w, h), _ctx))
ApiUsageException: exception ::omero::ApiUsageException
{
serverStackTrace = ome.conditions.ApiUsageException: Invalid C index: -1/2
at loci.formats.FormatTools.getIndex(FormatTools.java:325)
at loci.formats.FormatTools.getIndex(FormatTools.java:278)
at loci.formats.ChannelSeparator.getIndex(ChannelSeparator.java:258)
at ome.io.bioformats.BfPixelsWrapper.getTile(BfPixelsWrapper.java:356)
at ome.io.bioformats.BfPixelBuffer.getTileDirect(BfPixelBuffer.java:480)
at ome.services.RawPixelsBean.getTile(RawPixelsBean.java:777)
...

@will-moore
Copy link
Member Author

This will be rebased onto dev_4_4 as a new branch

@will-moore will-moore closed this Oct 17, 2012
@will-moore will-moore mentioned this pull request Oct 17, 2012
@ximenesuk ximenesuk mentioned this pull request Mar 28, 2013
snoopycrimecop pushed a commit to snoopycrimecop/omero-scripts that referenced this pull request Mar 5, 2014
snoopycrimecop pushed a commit to snoopycrimecop/omero-scripts that referenced this pull request Jan 7, 2022
Run scripts with environment variables
snoopycrimecop pushed a commit to snoopycrimecop/omero-scripts that referenced this pull request Jan 7, 2022
snoopycrimecop pushed a commit to snoopycrimecop/omero-scripts that referenced this pull request Jan 11, 2022
Run scripts with environment variables
snoopycrimecop pushed a commit to snoopycrimecop/omero-scripts that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants