[compression] fix compression management #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
I can't safely uncompress the output file.
To Reproduce
Steps to reproduce the behavior:
gzip
orlzma
as a compression algorythm.some-singer-tap | target-s3-jsonl --config [config.json]
Expected behavior
I expect to be able to uncompress the target output
Screenshots
If applicable, add screenshots to help explain your problem.
Your environment
0.0.5
3.8
Additional context
Basically the issue is due to the
if
instead ofelif
introduced withlzma
in thesave_file
function. It allow the uncompressed data to be appended to the file, hence the file inconsistency.