Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readlines] replace io.TextIOWrapper(sys.stdin.buffer, encoding=utf-8) with sys.stdin #13

Merged
merged 5 commits into from
Aug 13, 2021

Conversation

ome9ax
Copy link
Owner

@ome9ax ome9ax commented Aug 13, 2021

Objective

  • Improve the input reader's efficiency

Proposed changes

  • Simplify the way target reads stdin lines

Types of changes

What types of changes does your code introduce to target-s3-jsonl?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@ome9ax ome9ax added the enhancement New feature or request label Aug 13, 2021
@ome9ax ome9ax self-assigned this Aug 13, 2021
@ome9ax ome9ax added this to In progress in Singer Target s3 jsonl via automation Aug 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #13 (66e7bec) into main (3e76843) will increase coverage by 6.13%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   60.10%   66.23%   +6.13%     
==========================================
  Files           3        2       -1     
  Lines         198      154      -44     
  Branches       38       32       -6     
==========================================
- Hits          119      102      -17     
+ Misses         64       37      -27     
  Partials       15       15              
Flag Coverage Δ
unittests 66.23% <61.53%> (+6.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
target_s3_jsonl/__init__.py 64.86% <61.53%> (-0.50%) ⬇️
target_s3_jsonl/s3.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e76843...66e7bec. Read the comment docs.

@ome9ax ome9ax marked this pull request as ready for review August 13, 2021 09:37
@ome9ax ome9ax merged commit 0e6896b into main Aug 13, 2021
@ome9ax ome9ax deleted the feature/readlines branch August 13, 2021 09:40
Singer Target s3 jsonl automation moved this from In progress to Done Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants