Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coverage] release version 1.0.0 bump 🥳🥂🍾 tests & spec, 100% complete coverage #17

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

ome9ax
Copy link
Owner

@ome9ax ome9ax commented Aug 18, 2021

No description provided.

@ome9ax ome9ax added the enhancement New feature or request label Aug 18, 2021
@ome9ax ome9ax self-assigned this Aug 18, 2021
@ome9ax ome9ax added this to In progress in Singer Target s3 jsonl via automation Aug 18, 2021
@ome9ax ome9ax linked an issue Aug 18, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #17 (9dd397a) into main (638b359) will increase coverage by 2.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #17      +/-   ##
===========================================
+ Coverage   97.36%   100.00%   +2.63%     
===========================================
  Files           3         3              
  Lines         190       186       -4     
  Branches       36        35       -1     
===========================================
+ Hits          185       186       +1     
+ Misses          3         0       -3     
+ Partials        2         0       -2     
Flag Coverage Δ
unittests 100.00% <100.00%> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
target_s3_jsonl/__init__.py 100.00% <100.00%> (+2.05%) ⬆️
target_s3_jsonl/s3.py 100.00% <100.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 638b359...9dd397a. Read the comment docs.

@ome9ax ome9ax merged commit e20ebc4 into main Aug 18, 2021
@ome9ax ome9ax deleted the feature/coverage_100 branch August 18, 2021 17:30
Singer Target s3 jsonl automation moved this from In progress to Done Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Specs & test 100% coverage
2 participants