Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s3 upload] follow boto3 args order #18

Merged
merged 2 commits into from
Aug 18, 2021
Merged

[s3 upload] follow boto3 args order #18

merged 2 commits into from
Aug 18, 2021

Conversation

ome9ax
Copy link
Owner

@ome9ax ome9ax commented Aug 18, 2021

No description provided.

@ome9ax ome9ax self-assigned this Aug 18, 2021
@ome9ax ome9ax added this to In progress in Singer Target s3 jsonl via automation Aug 18, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #18 (ae96f5b) into main (e20ebc4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          186       185    -1     
  Branches        35        35           
=========================================
- Hits           186       185    -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
target_s3_jsonl/__init__.py 100.00% <ø> (ø)
target_s3_jsonl/logger.py 100.00% <100.00%> (ø)
target_s3_jsonl/s3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e20ebc4...ae96f5b. Read the comment docs.

@ome9ax ome9ax merged commit 7d6ee00 into main Aug 18, 2021
@ome9ax ome9ax deleted the feature/s3_upload branch August 18, 2021 19:10
Singer Target s3 jsonl automation moved this from In progress to Done Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants