Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decimal] precision fixed #75

Merged
merged 6 commits into from
Sep 2, 2022
Merged

[Decimal] precision fixed #75

merged 6 commits into from
Sep 2, 2022

Conversation

ome9ax
Copy link
Owner

@ome9ax ome9ax commented Aug 31, 2022

Fixes #69

@ome9ax ome9ax added the bug Something isn't working label Aug 31, 2022
@ome9ax ome9ax self-assigned this Aug 31, 2022
@ome9ax ome9ax added this to In progress in Singer Target s3 jsonl via automation Aug 31, 2022
@ome9ax ome9ax changed the title Hotfix/decimal precision [Decimal] precision fixed Aug 31, 2022
@ome9ax
Copy link
Owner Author

ome9ax commented Aug 31, 2022

@elenavelteremote @aroder FYI

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #75 (c33896a) into main (48e4993) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #75   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          198       190    -8     
  Branches        37        31    -6     
=========================================
- Hits           198       190    -8     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/target_s3_jsonl/logger.py 100.00% <ø> (ø)
src/target_s3_jsonl/s3.py 100.00% <ø> (ø)
src/target_s3_jsonl/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ome9ax ome9ax marked this pull request as ready for review September 2, 2022 18:41
@ome9ax ome9ax merged commit 6b56426 into main Sep 2, 2022
Singer Target s3 jsonl automation moved this from In progress to Done Sep 2, 2022
@ome9ax ome9ax deleted the hotfix/decimal_precision branch September 2, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

decimal.DivisionImpossible raised when handling schema items with high levels of precision
2 participants