chore: Enable govet linter and fix reported errors

[ghislainbourgeois]

Enables the govet linter and fix reported errors.

[onf-bot]

Can one of the admins verify this patch?

[onf-bot]

Can one of the admins verify this patch?

[gab-arrobo]

ok to test

[gab-arrobo]

@ghislainbourgeois, FYI. This branch is out-of-date with the base branch

[ghislainbourgeois]

@ghislainbourgeois, FYI. This branch is out-of-date with the base branch

Fixed

[gab-arrobo]

Why are these changes needed? These changes are not due to enabling govet, correct?

[ghislainbourgeois]

Yes and no, the changes made in metrics/kafka.go made this test fail because of a nil pointer. It was working before because the default value was an empty struct and a method could be dispatched, but the default value of a pointer is nil.

[gab-arrobo]

@ghislainbourgeois, did you have a chance to run an end-to-end test using the changes from this PR? I am asking this because I am running a test using AiaB (w/ gnbsim) and the test fails as shown below:

$ make 5g-test
...
...
2024-01-03T17:29:41Z [INFO][GNBSIM][Profile][profile2] ExecuteProfile ended
2024-01-03T17:29:41Z [INFO][GNBSIM][Summary] Profile Name: profile2 , Profile Type: pdusessest
2024-01-03T17:29:41Z [INFO][GNBSIM][Summary] Ue's Passed: 0 , Ue's Failed: 5
2024-01-03T17:29:41Z [INFO][GNBSIM][Summary] Profile Errors:
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007487, profile timeout
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007488, profile timeout
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007489, profile timeout
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007490, profile timeout
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007491, profile timeout
2024-01-03T17:29:41Z [INFO][GNBSIM][Summary] Profile Status: FAIL
make: *** [Makefile:679: 5g-test] Error 1

[ghislainbourgeois]

@ghislainbourgeois, did you have a chance to run an end-to-end test using the changes from this PR? I am asking this because I am running a test using AiaB (w/ gnbsim) and the test fails as shown below:

$ make 5g-test
...
...
2024-01-03T17:29:41Z [INFO][GNBSIM][Profile][profile2] ExecuteProfile ended
2024-01-03T17:29:41Z [INFO][GNBSIM][Summary] Profile Name: profile2 , Profile Type: pdusessest
2024-01-03T17:29:41Z [INFO][GNBSIM][Summary] Ue's Passed: 0 , Ue's Failed: 5
2024-01-03T17:29:41Z [INFO][GNBSIM][Summary] Profile Errors:
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007487, profile timeout
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007488, profile timeout
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007489, profile timeout
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007490, profile timeout
2024-01-03T17:29:41Z [ERRO][GNBSIM][Summary] imsi:imsi-208930100007491, profile timeout
2024-01-03T17:29:41Z [INFO][GNBSIM][Summary] Profile Status: FAIL
make: *** [Makefile:679: 5g-test] Error 1

I did not test with AiaB, I will investigate.

[gab-arrobo]

I did not test with AiaB, I will investigate.

Well, you do not have to use AiaB, but my point was to check whether you had tested the changes using an end-to-end test (e.g., AiaB, OnRamp, etc.)

[ghislainbourgeois]

I did not test with AiaB, I will investigate.

Well, you do not have to use AiaB, but my point was to check whether you had tested the changes using an end-to-end test (e.g., AiaB, OnRamp, etc.)

I had not yet no. I am able to reproduce the issue, and it seems to be because the mutex is uninitialized. I will push a fix.

[ghislainbourgeois]

I pushed a fix that I was able to confirm working end-to-end with gnbsim.

[gab-arrobo]

+1 (tested changes with AiaB)