Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move idgenerator dep to util project #187

Merged

Conversation

ghislainbourgeois
Copy link
Contributor

Changes the import path of the idgenerator module to use the util project. Tested with a successful simulation with gnbsim.

@gab-arrobo
Copy link
Contributor

@ghislainbourgeois, just to confirm, you are verifying that the code (functions, variables, etc.) from the "tiny" repo (idgenerator in this case) is exactly the same as the one in the util repo (util/idgenerator), correct?

@ghislainbourgeois
Copy link
Contributor Author

@ghislainbourgeois, just to confirm, you are verifying that the code (functions, variables, etc.) from the "tiny" repo (idgenerator in this case) is exactly the same as the one in the util repo (util/idgenerator), correct?

There are small differences that should not impact the behavior. But I ran a full test to make sure.

Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (tested changes with AiaB)

@gab-arrobo gab-arrobo merged commit baefee2 into omec-project:master Feb 1, 2024
7 checks passed
@ghislainbourgeois ghislainbourgeois deleted the move-idgenerator-dep branch February 1, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants