Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Deregistration Notification Implementation #214

Merged
merged 7 commits into from Apr 19, 2024
Merged

Handle Deregistration Notification Implementation #214

merged 7 commits into from Apr 19, 2024

Conversation

akhila-s06
Copy link
Contributor

This PR involves

  • Implementation of the handling of Deregistration Notification where 'DeregReason' is 'SUBSCRIPTION_WITHDRAWN'
  • Bug fix: Fixed the sending of extra paging message

@thakurajayL
Copy link
Contributor

  • Could you please tell how you tested this code?
  • Do you have captures of packets at AMF?
  • What tool was used to test it.

thakurajayL
thakurajayL reviewed Mar 20, 2024
View reviewed changes
context/amf_ran.go
@@ -161,7 +161,6 @@ func (ran *AmfRan) SetRanId(ranNodeId *ngapType.GlobalRANNodeID) {
if ranId.GNbId != nil {
ran.GnbId += ranId.GNbId.GNBValue
}
AMF_Self().AmfRanPool.Store(ran.GnbId, ran)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please tell us why this is removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The map 'amfranpool' was populated with two entries for single NG connection.
This line of code adds one extra entry to amfranpool for the same NG connection.
Therefore, two paging messages are send by AMF.
Furthermore, this extra line of code is found in omec-project/amf repository but not in free5gc/amf repository (https://github.com/free5gc/amf/blob/main/internal/context/amf_ran.go).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please share where is the other entry added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Attaching the screenshot of the function where the other entry is added.

NewAmfRan

The function 'NewAmfRan' is called in 'ngap/dispatcher.go' (https://github.com/omec-project/amf/blob/master/ngap/dispatcher.go#L116).

@akhila-s06
Copy link
Contributor Author

akhila-s06 commented Mar 22, 2024 •
edited

  • What tool was used to test it.
    We tested using the simulator in our lab environment.

gab-arrobo
gab-arrobo approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo gab-arrobo merged commit 6664805 into omec-project:master Apr 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thakurajayL thakurajayL thakurajayL approved these changes

@gab-arrobo gab-arrobo gab-arrobo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akhila-s06 @thakurajayL @gab-arrobo