chore: Adds staticcheck lint check #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok to test |
gab-arrobo
reviewed
Jan 4, 2024
gab-arrobo
reviewed
Jan 4, 2024
gab-arrobo
reviewed
Jan 5, 2024
producer/ue_authentication.go
Outdated
Comment on lines
30
to
38
| // Generates a random int between 0 and 255 | ||
| func GenerateRandomNumber() (uint8, error) { | ||
| randBytes := make([]byte, 1) | ||
| _, err := rand.Read(randBytes) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("error while generating random number: %s", err.Error()) | ||
| } | ||
| return randBytes[0], nil | ||
| } |
There was a problem hiding this comment.
Why having a "different" function compared to the one proposed/merged in NRF #52 (also, shown below)? Should not this function be pretty much the same as the one in the NRF repo?
// Generates a random int between 0 and 99
func GenerateRandomNumber() (int, error) {
max := big.NewInt(100)
randomNumber, err := rand.Int(rand.Reader, max)
if err != nil {
return 0, err
}
return int(randomNumber.Int64()), nil
}There was a problem hiding this comment.
I changed this to follow the same approach as in the NRF. I used to use bytes because we're outputting a value between 0-255 instead of an arbitrary value but it doesn't really make a difference. This is more standard with the last commit.
gab-arrobo
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
staticchecklint check and makes the required changes to have it pass.