Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add first unit tests #124

Merged
merged 5 commits into from
Jan 26, 2024
Merged

chore: Add first unit tests #124

merged 5 commits into from
Jan 26, 2024

Conversation

Gmerold
Copy link
Contributor

@Gmerold Gmerold commented Jan 24, 2024

  • Adds some first unit tests for the CI
  • Updates workflow file to run CI checks on every push

@onf-bot
Copy link
Contributor

onf-bot commented Jan 24, 2024

Can one of the admins verify this patch?

gab-arrobo
gab-arrobo reviewed Jan 25, 2024
View reviewed changes
common/events_test.go Outdated Show resolved Hide resolved
gab-arrobo
gab-arrobo approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo gab-arrobo merged commit 4e53c05 into omec-project:main Jan 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thakurajayL thakurajayL thakurajayL approved these changes

@gab-arrobo gab-arrobo gab-arrobo approved these changes

@ghislainbourgeois ghislainbourgeois Awaiting requested review from ghislainbourgeois

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gmerold @onf-bot @thakurajayL @ghislainbourgeois @gab-arrobo