New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding design documentation #26
Adding design documentation #26
Conversation
Adding desing documentation and removing old profiles
ed077e0
to
6f8f599
Compare
fmt.Println("Failed to write Security Mode Complete Message") | ||
return | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm what test this old profile was doing ? and do we have this support in new code ? if not can you open a bug and share number with me ?
|
||
package gutiregistration | ||
|
||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm what test this old profile was doing ? and do we have this support in new code ? if not can you open a bug and share number with me ?
@@ -1,82 +0,0 @@ | |||
// SPDX-FileCopyrightText: 2021 Open Networking Foundation <info@opennetworking.org> | |||
// | |||
// SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine to remove.
// SPDX-License-Identifier: Apache-2.0 | ||
// SPDX-License-Identifier: LicenseRef-ONF-Member-Only-1.0 | ||
|
||
package n2handover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine to remove
sendMsg, err = test.GetInitialContextSetupResponseForServiceRequest(ue.AmfUeNgapId, ue.RanUeNgapId, ranIpAddr) | ||
if err != nil { | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm what call flow this file was supporting ?
// SPDX-FileCopyrightText: 2021 Open Networking Foundation <info@opennetworking.org> | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// SPDX-License-Identifier: LicenseRef-ONF-Member-Only-1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm what call flow this file was supporting ?
package register | ||
|
||
import ( | ||
"encoding/hex" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to remove
package resynchronisation | ||
|
||
import ( | ||
"encoding/hex" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have JIRA task for this ?
// SPDX-FileCopyrightText: 2021 Open Networking Foundation <info@opennetworking.org> | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// SPDX-License-Identifier: LicenseRef-ONF-Member-Only-1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to remove this file
@@ -1,328 +0,0 @@ | |||
// SPDX-FileCopyrightText: 2021 Open Networking Foundation <info@opennetworking.org> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have JIRA task for this. Ok to remove
Adding desing documentation and removing old profiles