SDCORE-842: Adding Support for UE Requested PDU Session Release Procedure #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gajjarvini
commented
Mar 17, 2022
•
gajjarvini
commented
thakurajayL
reviewed
Mar 17, 2022
common/procedures.go
Outdated
| AN_RELEASE_PROCEDURE: "AN-RELEASE-PROCEDURE", | ||
| UE_TRIGGERED_SERVICE_REQUEST_PROCEDURE: "UE-TRIGGERED-SERVICE-REQUEST-PROCEDURE", | ||
| NW_TRIGGERED_UE_DEREGISTRATION_PROCEDURE: "NW-TRIGGERED-UE-DEREGISTRATION-PROCEDURE", | ||
| AMF_RELEASE_PROCEDURE: "AMF_RELEASE_PROCEDURE", |
There was a problem hiding this comment.
Could you please update "AMF_RELEASE_PROCEDURE" as well ? instead of _ , use - ?
thakurajayL
reviewed
Mar 17, 2022
common/procedures.go
Outdated
| } | ||
|
|
||
| func (id ProcedureType) String() string { | ||
| procStr, ok := procStrMap[id] | ||
| if !ok { | ||
| logger.AppLog.Fatalln("Invalid Procedure ID:", id) | ||
| logger.AppLog.Fatalf("Invaid Procedure ID: %#v", id) |
thakurajayL
reviewed
Mar 17, 2022
common/events.go
Outdated
| } | ||
|
|
||
| func (id EventType) String() string { | ||
| evtStr, ok := evtStrMap[id] | ||
| if !ok { | ||
| logger.AppLog.Fatalln("Invaid Event ID:", id) | ||
| logger.AppLog.Fatalf("Invaid Event ID: %#v", id) |
thakurajayL
reviewed
Mar 17, 2022
| @@ -164,7 +164,7 @@ func (cpTprt *GnbCpTransport) ReceiveFromPeer(peer transportcommon.TransportPeer | |||
| } | |||
| } | |||
|
|
|||
| cpTprt.Log.Infof("Read %v bytes from %v\n", n, conn) | |||
| cpTprt.Log.Infof("Read %v bytes from %v\n", n, amf.GetIpAddr()) | |||
| //TODO Post to gnbamfworker channel | |||
| gnbamfworker.HandleMessage(cpTprt.GnbInstance, amf, recvMsg[:n]) | |||
There was a problem hiding this comment.
Let's understand this more. If no task created for this then we should create one.
thakurajayL
reviewed
Mar 17, 2022
| return | ||
| } | ||
| if gnb == nil { | ||
| amf.Log.Errorln("GNodeB Message is nil") |
There was a problem hiding this comment.
message is nil ? or context is nil ?
thakurajayL
reviewed
Mar 17, 2022
| amf.Log.Errorln("RANUENGAPID is nil") | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
should we break if you find one occurrence of RANUENGAPID ?
…dure
1) Generating and processing NGAP/NAS message for the procedure
2) Terminating PDU Session Contexts in Real UE and gNodeB component
gajjarvini
force-pushed
the
temp
branch
2 times, most recently
from
149a534
to
6dd23ca
Compare
thakurajayL
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.