New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dnn parameter in config file #64
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
ok to test |
@@ -68,6 +69,7 @@ configuration: | |||
opc: "981d464c7c52eb6e5036234984ad0bcf" | |||
key: "5122250214c33e723a5dd523fc145fc0" | |||
sequenceNumber: "16f3b3f70fc2" | |||
dnn: "internet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it list ? just a thought. We would be supporting multiple PDU sessions at some point in time. or should we keep it simple for now ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep it simple now? We need to map dnnList with SliceSupportList for multiple PDU sessions for each UE.
I will try to create PR for that later. If it is okay then I have also addressed it for S-Nssai in latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please make a note that dnn and snssai is not list when it is added in PduSessionEstablishmentRequest
.
- Multiple
PduSessionEstablishmentRequest
need to be triggered based on this list (i.e it is to be handled beforefunc HandlePduSessEstRequestEvent
).
OR - We may need to address it before with optional IE
RequestedNssai
(which is not supported currently in gnbsim) in either first (initailUEMessage) or second (security mode complete) registration request message. And then based onRequestedNssai
by UE andAllowedNssai/ConfiguredNssai
by CN, we need to trigger multiplePduSessionEstablishmentRequest
Do you want to update NAS module tag in the gnbsim ? I just created tag for gas module v1.1.3 with PTI fix. |
Signed-off-by: kharade <rohan.kharade@openairinterface.org>
Addressed in latest commit |
Signed-off-by: kharade <rohan.kharade@openairinterface.org>
@@ -40,6 +40,9 @@ configuration: | |||
taiSliceSupportList: | |||
- sst: 1 # Slice/Service Type (uinteger, range: 0~255) | |||
sd: 010203 # Slice Differentiator (3 bytes hex string, range: 000000~FFFFFF) | |||
- sst: 1 | |||
sd: 000001 | |||
- sst: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if there is no sd ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not encoded in the NGSetupRequest message by Gnbsim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please point me to code where its skipped ? Approving code, assuming we will not be dealing with situation immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional field Sd encoding at NGAP
Hence it is decoded at AMF like this
NGSetupRequestIEs ::= {
id: 102
criticality: 0 (reject)
value: SupportedTAList ::= {
SupportedTAItem ::= {
tAC: 00 A0 00
broadcastPLMNList: BroadcastPLMNList ::= {
BroadcastPLMNItem ::= {
pLMNIdentity: 02 F8 59
tAISliceSupportList: SliceSupportList ::= {
SliceSupportItem ::= {
s-NSSAI: S-NSSAI ::= {
sST: 01
sD: 01 02 03
}
}
SliceSupportItem ::= {
s-NSSAI: S-NSSAI ::= {
sST: 01
sD: 00 00 01
}
}
SliceSupportItem ::= {
s-NSSAI: S-NSSAI ::= {
sST: 02
}
}
}
}
}
}
}
}
No description provided.