Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dnn parameter in config file #64

Merged
merged 3 commits into from Aug 16, 2022

Conversation

orion-belt
Copy link
Contributor

No description provided.

@onf-bot
Copy link
Contributor

onf-bot commented Aug 6, 2022

Can one of the admins verify this patch?

2 similar comments
@onf-bot
Copy link
Contributor

onf-bot commented Aug 6, 2022

Can one of the admins verify this patch?

@onf-bot
Copy link
Contributor

onf-bot commented Aug 6, 2022

Can one of the admins verify this patch?

@thakurajayL
Copy link
Contributor

ok to test

@@ -68,6 +69,7 @@ configuration:
opc: "981d464c7c52eb6e5036234984ad0bcf"
key: "5122250214c33e723a5dd523fc145fc0"
sequenceNumber: "16f3b3f70fc2"
dnn: "internet"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it list ? just a thought. We would be supporting multiple PDU sessions at some point in time. or should we keep it simple for now ?

Copy link
Contributor Author

@orion-belt orion-belt Aug 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep it simple now? We need to map dnnList with SliceSupportList for multiple PDU sessions for each UE.
I will try to create PR for that later. If it is okay then I have also addressed it for S-Nssai in latest commit.

Copy link
Contributor Author

@orion-belt orion-belt Aug 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please make a note that dnn and snssai is not list when it is added in PduSessionEstablishmentRequest.

  • Multiple PduSessionEstablishmentRequest need to be triggered based on this list (i.e it is to be handled before func HandlePduSessEstRequestEvent).
    OR
  • We may need to address it before with optional IE RequestedNssai (which is not supported currently in gnbsim) in either first (initailUEMessage) or second (security mode complete) registration request message. And then based on RequestedNssai by UE and AllowedNssai/ConfiguredNssai by CN, we need to trigger multiple PduSessionEstablishmentRequest

@thakurajayL
Copy link
Contributor

Do you want to update NAS module tag in the gnbsim ? I just created tag for gas module v1.1.3 with PTI fix.

Signed-off-by: kharade <rohan.kharade@openairinterface.org>
@orion-belt
Copy link
Contributor Author

Do you want to update NAS module tag in the gnbsim ? I just created tag for gas module v1.1.3 with PTI fix.

Addressed in latest commit

Signed-off-by: kharade <rohan.kharade@openairinterface.org>
@@ -40,6 +40,9 @@ configuration:
taiSliceSupportList:
- sst: 1 # Slice/Service Type (uinteger, range: 0~255)
sd: 010203 # Slice Differentiator (3 bytes hex string, range: 000000~FFFFFF)
- sst: 1
sd: 000001
- sst: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if there is no sd ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not encoded in the NGSetupRequest message by Gnbsim.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please point me to code where its skipped ? Approving code, assuming we will not be dealing with situation immediately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional field Sd encoding at NGAP

Hence it is decoded at AMF like this

            NGSetupRequestIEs ::= {
                id: 102
                criticality: 0 (reject)
                value: SupportedTAList ::= {
                    SupportedTAItem ::= {
                        tAC: 00 A0 00
                        broadcastPLMNList: BroadcastPLMNList ::= {
                            BroadcastPLMNItem ::= {
                                pLMNIdentity: 02 F8 59
                                tAISliceSupportList: SliceSupportList ::= {
                                    SliceSupportItem ::= {
                                        s-NSSAI: S-NSSAI ::= {
                                            sST: 01
                                            sD: 01 02 03
                                        }
                                    }
                                    SliceSupportItem ::= {
                                        s-NSSAI: S-NSSAI ::= {
                                            sST: 01
                                            sD: 00 00 01
                                        }
                                    }
                                    SliceSupportItem ::= {
                                        s-NSSAI: S-NSSAI ::= {
                                            sST: 02
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }

@thakurajayL thakurajayL merged commit 874f138 into omec-project:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants