Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci yml file and disable all linters #97

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Nov 14, 2023

  • Add .golanci.yml which includes linting directives for project and disable all linters.
  • The aim is fixing the gnbsim CI, then problems of each type of linter is being fixed in separate PR's.
  • Some ineffassign problems are fixed as they still causes error after disabling ineffassign in golangci.yaml.

Signed-off-by: gatici <gulsum.atici@canonical.com>
@onf-bot
Copy link
Contributor

onf-bot commented Nov 14, 2023

Can one of the admins verify this patch?

2 similar comments
@onf-bot
Copy link
Contributor

onf-bot commented Nov 14, 2023

Can one of the admins verify this patch?

@onf-bot
Copy link
Contributor

onf-bot commented Nov 14, 2023

Can one of the admins verify this patch?

@gatici
Copy link
Contributor Author

gatici commented Nov 14, 2023

$ make golint

level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="[lintersdb] Active 5 linters: [asciicheck dogsled godox gofmt ineffassign]"
level=info msg="[loader] Go packages loading at mode 575 (name|deps|imports|files|types_sizes|compiled_files|exports_file) took 8.686651164s"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 5.24274ms"
level=info msg="[linters_context/goanalysis] analyzers took 53.9245ms with top 10 stages: gofmt: 37.552071ms, ineffassign: 8.533969ms, asciicheck: 3.100171ms, godox: 2.750409ms, dogsled: 1.90461ms, typecheck: 83.27µs"
level=info msg="[runner] processing took 3.176µs with stages: max_same_issues: 388ns, skip_dirs: 346ns, nolint: 337ns, skip_files: 296ns, exclude-rules: 231ns, filename_unadjuster: 168ns, cgo: 158ns, autogenerated_exclude: 145ns, path_prettifier: 136ns, source_code: 133ns, exclude: 131ns, identifier_marker: 127ns, fixer: 126ns, max_from_linter: 114ns, diff: 52ns, path_shortener: 52ns, sort_results: 49ns, uniq_by_line: 49ns, max_per_file_from_linter: 49ns, severity-rules: 49ns, path_prefixer: 40ns"
level=info msg="[runner] linters took 164.486165ms with stages: goanalysis_metalinter: 164.441159ms"
level=info msg="File cache stats: 0 entries of total size 0B"
level=info msg="Memory: 90 samples, avg is 25.0MB, max is 98.4MB"
level=info msg="Execution took 8.860514265s"

@thakurajayL
Copy link
Contributor

ok to test

@thakurajayL
Copy link
Contributor

retest this please

@thakurajayL thakurajayL merged commit 3e4449f into omec-project:main Nov 22, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants