Move Makefile out of config folder #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
retest this please |
|
This patch, along with #64, is needed to avoid configuration backup of makefiles in ngic-rtc cp/dp. Manually tested successfully. |
cmaciocco
pushed a commit
that referenced
this pull request
Mar 28, 2019
Today the CI carries custom Makefiles and overwrites the Makefile in the repo, making it impossible to test updates to Makefiles themselves. Also these are currently opaque. Instead we make note of the diffs each scenario needs and include them in .mk files for cp and dp as per #18. This way developers can see how the CI tests. This will also allow to test changes to the base Makefiles. In a followo-on commit or PR we can even add config files and even the scripts CI uses to run the tests. This way we make CI repo minimal, and number of opaque things zero. Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
|
retest this please |
Removed config/ng-core_cfg.mk
Added custom-{cp,dp}.mk files under cp/dp respectively
{cp,dp}/Makefile include local *.mk file
Partial: #4
Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
|
retest this please |
|
@cmaciocco please merge this. CI passed with changes from #64 and omec-project/omec-project-ci#11 |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed config/ng-core_cfg.mk
Added custom-{cp,dp}.mk files under cp/dp respectively
{cp,dp}/Makefile include local *.mk file
Partial: #4
Signed-off-by: Saikrishna Edupuganti saikrishna.edupuganti@intel.com