[SDFAB-1110] Add support for application filter #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2022 20:34
added 14 commits
March 9, 2022 15:46
…add-multiple-sdf-filters
…add-multiple-sdf-filters
EmanueleGallone
changed the title
EmanueleGallone
force-pushed
the
add-multiple-sdf-filters
branch
5 times, most recently
from
34d259a
to
b4d2c7e
Compare
EmanueleGallone
force-pushed
the
add-multiple-sdf-filters
branch
from
b4d2c7e
to
a63006e
Compare
EmanueleGallone
changed the title
osinstom
reviewed
Mar 11, 2022
api/pfcpsim.proto
Outdated
| int32 qfi = 6; // Should be uint8 | ||
| bool gateClosed = 7; | ||
| bool gateClosed = 7; // If set, the application QERs will have the Gate status to closed. |
There was a problem hiding this comment.
Isn't gateClosed in conflict with appFilter now? What if we define gateClosed = true and appFilter = allow ? Which one have a precedence?
There was a problem hiding this comment.
Right. I removed the gate status flag. The only way to set the gate status is now by using the app-filter flag
osinstom
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR's aim is to add an application filter flag, using the format
<Protocol>:<IP>/<SubnetMask>:<Port>-<Port>:<Action>depends on :