Feat/urr #69

ianchen0119 · 2024-03-14T08:16:55Z

support to do the long-term test by using go test.
support to handle Session Report & URR-related IEs.

ianchen0119 · 2024-03-14T08:21:35Z

Could you please help to review the PR?
Thanks.

gab-arrobo

There are a few issues that need to be resolved such as apply gofmt to pkg/pfcpsim/session/urr_ies.go, add missing license/copyright headers to a couple files

fuzz/ie_fuzz_test.go

internal/pfcpsim/export/export.go

pkg/pfcpsim/session/urr_ies.go

.golangci.yml

Makefile

ianchen0119 · 2024-03-19T16:42:42Z

Hi @gab-arrobo

Do I need to do any enhancements for this PR?
If yes, please let me know when you feel free.

Many thanks.

gab-arrobo · 2024-03-19T16:44:56Z

Hi @gab-arrobo

Do I need to do any enhancements for this PR? If yes, please let me know when you feel free.

Many thanks.

Hi @ianchen0119, I will try to review your PR in the coming days and will get back to you

gab-arrobo

@ianchen0119, how did you test the changes/PR?

Makefile

gab-arrobo · 2024-03-20T22:54:28Z

@ianchen0119, I just enabled some additional linters. Please rebase your PR. Thank you!

ianchen0119 · 2024-03-21T02:02:01Z

@ianchen0119, how did you test the changes/PR?

Hi @gab-arrobo

After the UPF gets started, the fuzzing can be enabled.
It will connect to the UPF and try to send the malformed PFCP message to explore the potential security issue.

We can use the command below to trigger the fuzzing, for example:

go test -fuzz=Fuzz -p 1 -parallel 1 -fuzztime 15m ./fuzz/...

Furthermore, go-upf PR #33 is to fix the bug, reported by a community user, and it can be reproduced by the fuzzing.

andy89923 · 2024-03-27T06:43:02Z

Hello,

I push a commit to let PFCP accept the loopback interface.
Also, this PR was functional in my environment.

I run the UPF in host (10.10.0169), and run PFCPSIM on the same machine. It can create sessions, delete sessions, and also receive reports from UPF.

ianchen0119 · 2024-03-27T08:46:51Z

Hi @gab-arrobo
Could you please help to approve the CI workflow?

Thank you.

gab-arrobo · 2024-03-27T18:40:07Z

Hello,

I push a commit to let PFCP accept the loopback interface. Also, this PR was functional in my environment.

I run the UPF in host (10.10.0169), and run PFCPSIM on the same machine. It can create sessions, delete sessions, and also receive reports from UPF.

Thanks for your input/update. I am going to try it.

gab-arrobo

Overall, looks good to me.

Makefile

README.md

fuzz/ie_fuzz_test.go

andy89923 · 2024-03-28T05:09:49Z

Hello,

Thanks for the suggestion! @gab-arrobo

These were what I did in the latest commit:

Added the args to fuzz test for user-friendly run testing
Fix typo in code comments
Update README.md about how to use fuzzy test and the expected/unexpected result output

sureshmarikkannu

I didn't get a chance to test this PR (i haven't tried pfcpsim yet) and i walkthrough the changes from coding perspective and it looks good to me.

README.md

gab-arrobo

+1 (Run a test using UPF w/ OnRamp)

gab-arrobo · 2024-03-29T16:33:06Z

pkg/pfcpsim/pfcpsim.go

 		}
 	}
 }

-func (c *PFCPClient) ConnectN4(remoteAddr string) error {
+func (c *PFCPClient) ConnectN4(ctx context.Context, remoteAddr string) error {


@ianchen0119, why do you need to add context to this function? Does not it already have context when the NewPFCPClient is created/called (https://github.com/omec-project/pfcpsim/blob/main/pkg/pfcpsim/pfcpsim.go#L112)?

I think it's used for receiveFromN4().

pfcpsim/pkg/pfcpsim/pfcpsim.go

Line 235 in 2f3579b

go c.receiveFromN4(ctx)

And receiveFromN4():

pfcpsim/pkg/pfcpsim/pfcpsim.go

Line 169 in 2f3579b

func (c *PFCPClient) receiveFromN4(ctx context.Context) {

Hi @gab-arrobo @andy89923

I Just created the PR to fix it: #74

README.md

gab-arrobo reviewed Mar 14, 2024

View reviewed changes

fuzz/ie_fuzz_test.go Show resolved Hide resolved

internal/pfcpsim/export/export.go Outdated Show resolved Hide resolved

ianchen0119 force-pushed the feat/urr branch from 1dee39f to bea5902 Compare March 15, 2024 10:14

gab-arrobo reviewed Mar 15, 2024

View reviewed changes

pkg/pfcpsim/session/urr_ies.go Outdated Show resolved Hide resolved

gab-arrobo reviewed Mar 15, 2024

View reviewed changes

.golangci.yml Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

ianchen0119 and others added 17 commits March 16, 2024 19:00

support: URR related IEs

d408b76

ignore session report msg in PeekNextResponse()

dade9b5

print log msg when received session report related msg

9fcaeab

upgrade to golang 1.18 & go-pfcp v0.0.19

c251713

update urr related handlers

77d2824

support to handle sessionReport

21db935

add fuzz package

40b9121

support ie fuzzing

4625047

update Fuzzing Test

222ad0d

ignore HeartbeatRequest

898a43e

fix ci linter error

d877fbd

package rename

8907dbe

add license/copyright header

1d69794

update makefile

d0ed6b9

Fix lint issue

e56d4f7

fix gosec G404 & update behavior of test target in Makefile

5c81b4d

update go.mod

9f79a09

ianchen0119 force-pushed the feat/urr branch from cb200d8 to 9f79a09 Compare March 16, 2024 19:10

fix ci-lint error in fuzz test

bd74ad7

ianchen0119 force-pushed the feat/urr branch from cbbf145 to bd74ad7 Compare March 18, 2024 05:26

gab-arrobo reviewed Mar 20, 2024

View reviewed changes

Makefile Show resolved Hide resolved

ianchen0119 and others added 4 commits March 22, 2024 11:04

Merge remote-tracking branch 'origin/main' into feat/urr

11acbe7

update README

6c42b46

fix ci linter error

e9dc828

fix: support loopback interface

8e72c4b

Update .gitignore

56dee82

gab-arrobo reviewed Mar 27, 2024

View reviewed changes

fix: update typo and add args for fuzz test

b373b76

andy89923 force-pushed the feat/urr branch from ee28565 to 7aa3b86 Compare March 28, 2024 04:58

doc: update README

fecab46

andy89923 force-pushed the feat/urr branch from 7aa3b86 to fecab46 Compare March 28, 2024 05:00

sureshmarikkannu reviewed Mar 28, 2024

View reviewed changes

gab-arrobo reviewed Mar 28, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

8375047

gab-arrobo approved these changes Mar 28, 2024

View reviewed changes

gab-arrobo merged commit 2f3579b into omec-project:main Mar 28, 2024
7 checks passed

ianchen0119 deleted the feat/urr branch March 28, 2024 16:16

gab-arrobo reviewed Mar 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/urr #69

Feat/urr #69

ianchen0119 commented Mar 14, 2024

ianchen0119 commented Mar 14, 2024 •

edited

gab-arrobo left a comment

ianchen0119 commented Mar 19, 2024

gab-arrobo commented Mar 19, 2024

gab-arrobo left a comment •

edited

gab-arrobo commented Mar 20, 2024

ianchen0119 commented Mar 21, 2024

andy89923 commented Mar 27, 2024

ianchen0119 commented Mar 27, 2024

gab-arrobo commented Mar 27, 2024

gab-arrobo left a comment

andy89923 commented Mar 28, 2024

sureshmarikkannu left a comment

gab-arrobo left a comment

gab-arrobo Mar 29, 2024 •

edited

andy89923 Apr 1, 2024

ianchen0119 Apr 1, 2024

Feat/urr #69

Feat/urr #69

Conversation

ianchen0119 commented Mar 14, 2024

ianchen0119 commented Mar 14, 2024 • edited

gab-arrobo left a comment

Choose a reason for hiding this comment

ianchen0119 commented Mar 19, 2024

gab-arrobo commented Mar 19, 2024

gab-arrobo left a comment • edited

Choose a reason for hiding this comment

gab-arrobo commented Mar 20, 2024

ianchen0119 commented Mar 21, 2024

andy89923 commented Mar 27, 2024

ianchen0119 commented Mar 27, 2024

gab-arrobo commented Mar 27, 2024

gab-arrobo left a comment

Choose a reason for hiding this comment

andy89923 commented Mar 28, 2024

sureshmarikkannu left a comment

Choose a reason for hiding this comment

gab-arrobo left a comment

Choose a reason for hiding this comment

gab-arrobo Mar 29, 2024 • edited

Choose a reason for hiding this comment

andy89923 Apr 1, 2024

Choose a reason for hiding this comment

ianchen0119 Apr 1, 2024

Choose a reason for hiding this comment

ianchen0119 commented Mar 14, 2024 •

edited

gab-arrobo left a comment •

edited

gab-arrobo Mar 29, 2024 •

edited