New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitrate support in simapp #25
Conversation
simapp.go
Outdated
@@ -163,9 +166,11 @@ type ApplicationFilteringRules struct { | |||
// port range end | |||
EndPort int32 `yaml:"end-port,omitempty" json:"end-port,omitempty"` | |||
|
|||
AppMbrUplink int32 `yaml:"app-mbr-uplink,omitempty" json:"app-mbr-uplink,omitempty"` | |||
AppMbrUplink int64 `yaml:"app-mbr-uplink,omitempty" json:"app-mbr-uplink,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep it as is
AppMbrDownlink int32 `yaml:"app-mbr-downlink,omitempty" json:"app-mbr-downlink,omitempty"` | ||
AppMbrDownlink int64 `yaml:"app-mbr-downlink,omitempty" json:"app-mbr-downlink,omitempty"` | ||
|
||
BitRateUnit string `yaml:"bitrate-unit,omitempty" json:"bitrate-unit,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bitrate-unit or bitrateUnit ?
886662d
to
2741237
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No description provided.