Fix downlink FAR applyaction #37
Conversation
|
@badhrinathpa @thakurajayL @krsna1729... Please review the patch |
| @@ -523,11 +523,11 @@ func (dataPath *DataPath) ActivateTunnelAndPDR(smContext *SMContext, precedence | |||
| nextDLTunnel := nextDLDest.DownLinkTunnel | |||
|
|
|||
| DLFAR.ApplyAction = pfcpType.ApplyAction{ | |||
| Buff: false, | |||
| Buff: true, | |||
There was a problem hiding this comment.
Why buffer true during establishment req ? Can we not keep it drop ? and during this time when UE has not sent any packet do we expect downlink packet to flow ?
There was a problem hiding this comment.
@deepaks2 : When is the buffering action is set back to Forward ?
There was a problem hiding this comment.
The buffering action rule is created by the SMF and associated with the FAR in order to apply a specific
buffering behavior for DL packets requested to be buffered, as described in clause 5.8.3 and clause 5.2.4
in TS 29.244 [65].
-
buffer is enabled in downlink packets by setting the BUFF flag and by optionally provisioning buffering parameters providing instructions on how to buffer the packets; (5.2.3 Forwarding Action Rule Handling)
-
5GC supports buffering of UE's data packets for deactivated PDU Sessions and UP tunnel management
(more details in 5.8.3 Explicit Buffer Management (in TS 29.244 [65].)) -
The buffering is mandatory in UPF but optional in SMF.
There was a problem hiding this comment.
@deepaks2 : Since PFCP Modification request shall set action to forward and disable buffering, approving the pull request.
|
retest this please |
|
Thanks @UpadhyayaAnkur. I will re-test it |
…abilisment Signed-off-by: Deepak S <deepak.s@intel.com>
deepaks2
force-pushed
the
fix-downlink-far-action
branch
from
d299abb
to
cb3acff
Compare
|
retest this please |
|
@UpadhyayaAnkur which file is giving the FOSSA issue? Does it matter when not creating new files? |
Looks to be Fossa server issue. Observing timeout, nothing wrong with the changes. I have already approved code, please proceed with merge |
Set DownLink FAR applyAction to buffer & nocp during PFCP session establishment