SDCORE-209: PFCP Deletion Timeout Handling #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthiruveedula
requested review from
UpadhyayaAnkur,
thakurajayL and
badhrinathpa
and removed request for
UpadhyayaAnkur and
thakurajayL
| @@ -941,6 +943,13 @@ func HandlePDUSessionSMContextRelease(smContextRef string, body models.ReleaseSm | |||
| Body: nil, | |||
| } | |||
|
|
|||
| case smf_context.SessionReleaseTimeout: | |||
| smContext.SubCtxLog.Traceln("PDUSessionSMContextRelease, PFCP SessionReleaseTimeout") | |||
| smContext.ChangeState(smf_context.Active) | |||
There was a problem hiding this comment.
why do we move to active state here??
There was a problem hiding this comment.
these smf states confuse me too.. i coped from other failure cases.. I should understand these flags from Ankur
|
retest this please |
vthiruveedula
force-pushed
the
SDCORE-209
branch
from
bfded32
to
033110d
Compare
|
retest this please |
vthiruveedula
force-pushed
the
SDCORE-209
branch
from
033110d
to
93b73fb
Compare
|
retest this please |
1 similar comment
|
retest this please |
| @@ -322,7 +322,7 @@ func SendPfcpSessionModificationResponse(addr *net.UDPAddr) { | |||
| } | |||
|
|
|||
| func SendPfcpSessionDeletionRequest(upNodeID pfcpType.NodeID, ctx *smf_context.SMContext) (seqNum uint32) { | |||
| pfcpMsg, err := BuildPfcpSessionDeletionRequest() | |||
| pfcpMsg, err := BuildPfcpSessionDeletionRequest(upNodeID, ctx) | |||
| if err != nil { | |||
| ctx.SubPfcpLog.Errorf("Build PFCP Session Deletion Request failed: %v", err) | |||
| return | |||
There was a problem hiding this comment.
Returning on build PFCP Deletion req failure might not help. Probably, we can just discuss this once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.