Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE when removing PDRs #59

Closed
ccascone opened this issue Aug 14, 2020 · 1 comment
Closed

NPE when removing PDRs #59

ccascone opened this issue Aug 14, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ccascone
Copy link
Contributor

ccascone commented Aug 14, 2020

I've seen this once. The full ONOS log is attached.

java.lang.NullPointerException
	at org.omecproject.up4.behavior.FabricUpfProgrammable.removePdr(FabricUpfProgrammable.java:344)
	at org.omecproject.up4.impl.Up4NorthComponent.translateAndDelete(Up4NorthComponent.java:145)
	at org.omecproject.up4.impl.Up4NorthComponent$Up4NorthService.write(Up4NorthComponent.java:352)
	at p4.v1.P4RuntimeGrpc$MethodHandlers.invoke(P4RuntimeGrpc.java:467)
	at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:171)
	at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
	at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:808)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

up4-onos.log

@robertmacdavid
Copy link
Contributor

This should be fixed by #61, but I need your confirmation

robertmacdavid added a commit that referenced this issue Aug 19, 2020
* Fix null pointer exceptions

* removed magic number

* Update app/api/src/main/java/org/omecproject/up4/PacketDetectionRule.java

Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>

* missing constant

Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants