Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDFAB-186] Up4Service to expose network-level API #153

Merged
merged 3 commits into from
Jun 4, 2021
Merged

[SDFAB-186] Up4Service to expose network-level API #153

merged 3 commits into from
Jun 4, 2021

Conversation

daniele-moro
Copy link
Collaborator

Refactor Up4Service to expose UPF network-level API.
The Up4Service implementation is in charge of selecting the right UPF programmable.

@codecov
Copy link

codecov bot commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #153 (257bb44) into master (d51ec44) will decrease coverage by 1.04%.
The diff coverage is 24.59%.

❗ Current head 257bb44 differs from pull request most recent head 7d5e620. Consider uploading reports for the commit 7d5e620 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
- Coverage     57.99%   56.95%   -1.05%     
  Complexity      204      204              
============================================
  Files            16       16              
  Lines          2183     2223      +40     
  Branches        259      260       +1     
============================================
  Hits           1266     1266              
- Misses          798      838      +40     
  Partials        119      119
Impacted Files Coverage Δ
...ava/org/omecproject/up4/impl/Up4DeviceManager.java 12.50% <0.00%> (-2.02%) ⬇️
...va/org/omecproject/up4/impl/Up4NorthComponent.java 53.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51ec44...7d5e620. Read the comment docs.

@daniele-moro daniele-moro changed the title [WIP] [SDFAB-186] Up4Service to expose network-level API [SDFAB-186] Up4Service to expose network-level API Jun 3, 2021
@daniele-moro
Copy link
Collaborator Author

@ccascone @pierventre
I can't add reviewers, not sure why.

@pierventre pierventre requested a review from ccascone June 3, 2021 20:08
ccascone
ccascone approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@ccascone ccascone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left just a minor comment. Feel free to merge after fixing that (I'm giving you write permissions, so you should also be able to add reviewers).

app/app/src/main/java/org/omecproject/up4/impl/Up4DeviceManager.java Outdated Show resolved Hide resolved
@daniele-moro
Expose UPF network level API from Up4Service
e73354a 
Refactor Up4Service to expose UPF network level API.
The Up4Service implementation is in charge of selecting
the UPF programmable.
@daniele-moro
Always use get upf programmable in device manager
f5186fe
@daniele-moro
Copy link
Collaborator Author

@ccascone I believe I don't have write permission. Anyway, I rebased and now it can be merged.

@daniele-moro
Copy link
Collaborator Author

Waiting on @pierventre review before merging.

pierventre
pierventre reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@pierventre pierventre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly clarifications

app/api/src/main/java/org/omecproject/up4/Up4Service.java Show resolved Hide resolved
app/api/src/main/java/org/omecproject/up4/Up4Service.java Show resolved Hide resolved
app/api/src/main/java/org/omecproject/up4/Up4Service.java Show resolved Hide resolved
app/api/src/main/java/org/omecproject/up4/Up4Service.java Show resolved Hide resolved
app/app/src/main/java/org/omecproject/up4/impl/Up4DeviceManager.java Show resolved Hide resolved
app/app/src/main/java/org/omecproject/up4/impl/Up4DeviceManager.java Show resolved Hide resolved
@pierventre pierventre merged commit bac879c into omec-project:master Jun 4, 2021
@daniele-moro daniele-moro linked an issue Jul 5, 2021 that may be closed by this pull request
Promote UpfProgrammable to ONOS driver behavior #81
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccascone ccascone ccascone approved these changes

@pierventre pierventre pierventre approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promote UpfProgrammable to ONOS driver behavior
3 participants
@daniele-moro @ccascone @pierventre