Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDFAB-189] [SDFAB-187] Replace UpfProgrammable implementation with driver behaviour #158

Merged
merged 14 commits into from
Jun 18, 2021
Merged

[SDFAB-189] [SDFAB-187] Replace UpfProgrammable implementation with driver behaviour #158

merged 14 commits into from
Jun 18, 2021

Conversation

daniele-moro
Copy link
Collaborator

@daniele-moro daniele-moro commented Jun 16, 2021

The following patches/PR are needed before this being merged:

TODO:

  • depends on ONOS 2.5-SNAPSHOT when ONOS patches are backported to onos-2.5
  • Revert 3bc919e to use the maven artifacts from sonatype

@daniele-moro daniele-moro requested review from ccascone and pierventre and removed request for ccascone and pierventre June 16, 2021 14:34
@daniele-moro
Copy link
Collaborator Author

@pierventre

Copy link
Contributor

@ccascone ccascone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the dependency on fabric-v1model and fabric-tna

app/app/pom.xml Outdated Show resolved Hide resolved
app/app/pom.xml Outdated Show resolved Hide resolved
app/pom.xml Outdated Show resolved Hide resolved
@daniele-moro
Copy link
Collaborator Author

We should remove the dependency on fabric-v1model and fabric-tna

Done, dependency to fabric and fabric-tna were required only for the CLI commands, I'll port them to the driver behaviour. I'll open a Jira task to keep track of it.

Copy link
Contributor

@ccascone ccascone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #158 (d0df6d6) into master (95f63af) will decrease coverage by 17.64%.
The diff coverage is 59.91%.

❗ Current head d0df6d6 differs from pull request most recent head cfc934e. Consider uploading reports for the commit cfc934e to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master     #158       +/-   ##
=============================================
- Coverage     56.95%   39.30%   -17.65%     
+ Complexity      204      106       -98     
=============================================
  Files            16       12        -4     
  Lines          2223     1557      -666     
  Branches        260      169       -91     
=============================================
- Hits           1266      612      -654     
- Misses          838      883       +45     
+ Partials        119       62       -57     
Impacted Files Coverage Δ
...in/java/org/omecproject/up4/impl/AppConstants.java 100.00% <ø> (ø)
...ava/org/omecproject/up4/impl/Up4DeviceManager.java 10.40% <0.00%> (-2.10%) ⬇️
...a/org/omecproject/up4/impl/Up4P4InfoConstants.java 100.00% <ø> (ø)
...va/org/omecproject/up4/impl/Up4TranslatorUtil.java 50.00% <ø> (ø)
...va/org/omecproject/up4/impl/Up4TranslatorImpl.java 86.79% <86.79%> (ø)
...va/org/omecproject/up4/impl/Up4NorthComponent.java 53.71% <90.90%> (ø)
.../java/org/omecproject/up4/impl/SouthConstants.java 0.00% <0.00%> (-100.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f63af...cfc934e. Read the comment docs.

@ccascone ccascone merged commit 98e1591 into omec-project:master Jun 18, 2021
@ccascone ccascone changed the title [SDFAB-189] [SDFAB-187] Remove UpfProgrammable implementation, rely instead on behaviour [SDFAB-189] [SDFAB-187] Replace UpfProgrammable implementation with driver behaviour Jun 18, 2021
@daniele-moro daniele-moro linked an issue Jul 5, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Promote UpfProgrammable to ONOS driver behavior
3 participants