-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDFAB-189] [SDFAB-187] Replace UpfProgrammable implementation with driver behaviour #158
[SDFAB-189] [SDFAB-187] Replace UpfProgrammable implementation with driver behaviour #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the dependency on fabric-v1model and fabric-tna
app/app/src/main/java/org/omecproject/up4/cli/ReadInternalStoresCommandTna.java
Outdated
Show resolved
Hide resolved
app/app/src/main/java/org/omecproject/up4/cli/ReadInternalStoresCommandV1model.java
Outdated
Show resolved
Hide resolved
Done, dependency to fabric and fabric-tna were required only for the CLI commands, I'll port them to the driver behaviour. I'll open a Jira task to keep track of it. |
app/app/src/test/java/org/omecproject/up4/behavior/MockP4RuntimeClient.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=============================================
- Coverage 56.95% 39.30% -17.65%
+ Complexity 204 106 -98
=============================================
Files 16 12 -4
Lines 2223 1557 -666
Branches 260 169 -91
=============================================
- Hits 1266 612 -654
- Misses 838 883 +45
+ Partials 119 62 -57
Continue to review full report at Codecov.
|
The following patches/PR are needed before this being merged:
TODO: