Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaling test bug fix #188

Merged
merged 1 commit into from Dec 18, 2020
Merged

scaling test bug fix #188

merged 1 commit into from Dec 18, 2020

Conversation

badhrinathpa
Copy link
Contributor

No description provided.

@krsna1729
Copy link
Member

krsna1729 commented Dec 18, 2020

This is a regression introduced with interface PR #185 which used older version of master for refactoring. Commit previous to it had this
https://github.com/omec-project/upf-epc/blob/c98b3c31270bbe34c7ced0327089c462cacd8bae/pfcpiface/upf.go#L251-L255

@krsna1729
Copy link
Member

please make sure there is no other diff introduced with #185

@badhrinathpa
Copy link
Contributor Author

This is a regression introduced with interface PR #185 which used older version of master for refactoring. Commit previous to it had this

https://github.com/omec-project/upf-epc/blob/c98b3c31270bbe34c7ced0327089c462cacd8bae/pfcpiface/upf.go#L251-L255

Yes. This was present in previous master and we missed moving this to bess.go. Did a code review again to check if something else is missed. Didn't find anything else.

@thakurajayL thakurajayL merged commit cf63b02 into master Dec 18, 2020
@thakurajayL thakurajayL deleted the bug_fix branch December 18, 2020 18:23
badhrinathpa added a commit to badhrinathpa/upf-epc that referenced this pull request Jan 22, 2021
Co-authored-by: Badhrinath Pa <badhrinath@opennetworking.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants