Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conf parsing #224

Merged
merged 2 commits into from Mar 1, 2021
Merged

Fix conf parsing #224

merged 2 commits into from Mar 1, 2021

Conversation

krsna1729
Copy link
Member

  1. Fix hwcksum init
  2. Fix json bool parsing

@krsna1729
Fix hwcksum initialization
dafe34b 
Use hwcksum config value of parser

1. for port init
2. to simplify checksum module init and connection

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix json bool parsing in python
3bd595a 
Explicity match the string true/True

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729 krsna1729 requested a review from deepaks2 March 1, 2021 15:14
@krsna1729 krsna1729 merged commit 169ec0c into master Mar 1, 2021
@krsna1729 krsna1729 deleted the fix-conf-parsing branch March 1, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepaks2 deepaks2 deepaks2 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krsna1729 @deepaks2