Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable all golangci linters #242

Merged
merged 1 commit into from Aug 13, 2021
Merged

enable all golangci linters #242

merged 1 commit into from Aug 13, 2021

Conversation

krsna1729
Copy link
Member

@krsna1729 krsna1729 commented Mar 30, 2021 •
edited

This is equivalent of #205

@krsna1729 krsna1729 changed the title Update golangci-lint.yml enable all golangci linters Mar 30, 2021
@krsna1729
Copy link
Member Author

krsna1729 commented Mar 30, 2021 •
edited

There is a limit of 10 annotations from GH actions however. So we need to open the check itself to get list of all errors.

https://github.community/t/maximum-number-of-annotations-that-can-be-created-using-github-actions-logging-commands/16991

https://github.com/omec-project/upf-epc/runs/2227594732?check_suite_focus=true
Also this is why we dont see filename/line numbers in the action output
golangci/golangci-lint-action#119

@krsna1729 krsna1729 marked this pull request as ready for review March 30, 2021 12:42
@krsna1729 krsna1729 requested a review from deepaks2 May 13, 2021 04:26
@github-actions
Copy link

This pull request has been stale for 30 days and will be closed in 5 days. Comment to keep it open.

@krsna1729 krsna1729 force-pushed the test-golangci branch 3 times, most recently from 9f6a0b0 to aca2ab4 Compare August 13, 2021 04:48
badhrinathpa
badhrinathpa approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@badhrinathpa badhrinathpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@badhrinathpa badhrinathpa merged commit 635b4d4 into master Aug 13, 2021
@badhrinathpa badhrinathpa deleted the test-golangci branch August 13, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badhrinathpa badhrinathpa badhrinathpa approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krsna1729 @badhrinathpa