Add GTP PDU Session Container to encap module #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change FAR `action` values to match PDU type UL/DL in up4.bess, upf.go - Add extension header and psc structs - Use `action` metadata to set PDU type Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
- Add upf.json conf gtppsc to control insertion of PSC - Add GtpuEncapArg to protobuf/module_msg.proto - Precalculate encap_size for prepend, copy and len Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
krsna1729
force-pushed
the
psc-encap
branch
2 times, most recently
from
52c2a0f
to
0f87235
Compare
thakurajayL
approved these changes
May 3, 2021
| @@ -210,7 +210,7 @@ pdrLookup:GTPUDecap \ | |||
|
|
|||
| # Add logical pipeline when gtpuencap is needed | |||
| farLookup:GTPUEncap \ | |||
| -> gtpuEncap::GtpuEncap():1 \ | |||
| -> gtpuEncap::GtpuEncap(add_psc=parser.gtppsc):1 \ | |||
There was a problem hiding this comment.
can we not make it per call ?So that pfcp agent can control when to include this extension header.
There was a problem hiding this comment.
@thakurajayL in future yes. we will need to work out the details of how that is conveyed along with the QER stuff.
There was a problem hiding this comment.
But I feel like its not just about QFI is present or not. We anyway have to have the header for PDU type. When we want to support both 4G/5G concurrently in the same instance I feel like the expectation is on the eNB to ignore the extensions? That way we can keep it ON at an instance level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GTP PDU Session Container to encap module
actionvalues to match PDU type UL/DL in up4.bess, upf.goactionmetadata to set PDU typeConditionally add PDU session container GTPU encap
Signed-off-by: Saikrishna Edupuganti saikrishna.edupuganti@intel.com