apn fqdn encode fix #319
Merged
apn fqdn encode fix #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update the description of the commit and the first comment in this conversation. Have the description point to relevant section of spec. Also should this be handled upstream in go-pfcp library or not. |
badhrinathpa
force-pushed
the
apn_update
branch
from
f5cf512
to
bec84b7
Compare
krsna1729
reviewed
Aug 14, 2021
pfcpiface/messages.go
Outdated
| @@ -73,6 +73,7 @@ func (pc *PFCPConn) handleAssociationSetupRequest(upf *upf, msg message.Message, | |||
| // Timestamp shouldn't be the time message is sent in the real deployment but anyway :D | |||
| log.Println("Dnn info : ", upf.dnn) | |||
|
|
|||
| networkInstance := encodeFQDN(upf.dnn) | |||
There was a problem hiding this comment.
Suggested change
| networkInstance := encodeFQDN(upf.dnn) | |
| networkInstance := string(ie.NewNetworkInstanceFQDN(upf.dnn).Payload) |
There was a problem hiding this comment.
is ie.NewNetworkInstanceFQDN available in go-pfcp ?
There was a problem hiding this comment.
krsna1729
reviewed
Aug 14, 2021
pfcpiface/utils.go
Outdated
Comment on lines
42
to
57
| func encodeFQDN(fqdn string) string { | ||
| b := make([]byte, len(fqdn)+1) | ||
|
|
||
| var offset int | ||
|
|
||
| for _, label := range strings.Split(fqdn, ".") { | ||
|
|
||
| l := len(label) | ||
| b[offset] = uint8(l) | ||
| copy(b[offset+1:], label) | ||
| offset += l + 1 | ||
| } | ||
|
|
||
| return string(b) | ||
| } | ||
|
|
|
Split the commits for DNN and lint fixes |
badhrinathpa
force-pushed
the
apn_update
branch
from
bec84b7
to
55b08f2
Compare
krsna1729
reviewed
Aug 16, 2021
pfcpiface/messages.go
Outdated
| @@ -73,6 +73,7 @@ func (pc *PFCPConn) handleAssociationSetupRequest(upf *upf, msg message.Message, | |||
| // Timestamp shouldn't be the time message is sent in the real deployment but anyway :D | |||
| log.Println("Dnn info : ", upf.dnn) | |||
|
|
|||
| networkInstance := string(ie.NewNetworkInstanceFQDN("internet").Payload) | |||
There was a problem hiding this comment.
Suggested change
| networkInstance := string(ie.NewNetworkInstanceFQDN("internet").Payload) | |
| networkInstance := string(ie.NewNetworkInstanceFQDN(upf.dnn).Payload) |
badhrinathpa
force-pushed
the
apn_update
branch
from
55b08f2
to
021252e
Compare
krsna1729
approved these changes
Aug 16, 2021
|
retest this please |
1 similar comment
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PFCP versions before 16.3 we send User Plane IP Resource Information in association setup response.
This contains the network instance (DNN) parameter which should be encoded as FQDN. But it is encoded as string.
This can be fixed in the go-pfcp library also. But since the whole User Plane IP Resource Information parameter itself is deprecated, we are doing this change in pfcp agent. This will be updated when we start supporting release 16 and above in 5gc and upf.