Cleanly allow IP address provided as node id #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krsna1729
force-pushed
the
minor-cleanup
branch
from
0b39bd5
to
08ff24d
Compare
krsna1729
changed the title
Remove the TODO of correctly figuring out if node_id passed is FQDN or IPv4 or IPv6 Once figured out cache the result in PFCPConn.nodeID Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
krsna1729
force-pushed
the
minor-cleanup
branch
from
08ff24d
to
91e8725
Compare
Move the following into NewPFCPConn - Updation of conneciton map - Handling first message - launch Serve goroutine Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
|
|
||
| go p.Serve() | ||
|
|
||
| return p |
There was a problem hiding this comment.
can remove return val.
There was a problem hiding this comment.
we need this if we are initiating the connection. So we can call send association on this returned value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the TODO of correctly figuring out if node_id passed is FQDN or IPv4 or IPv6
Once figured out cache the result in PFCPConn.nodeID
Signed-off-by: Saikrishna Edupuganti saikrishna.edupuganti@intel.com