Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not dereference getPortStats gRPC message pointer on error #359

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Do not dereference getPortStats gRPC message pointer on error #359

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f09d8ec
Do not dereference `getPortStats` gRPC message pointer on error
pudelkoM Nov 9, 2021
106c76d
Re-add error message from response
pudelkoM Nov 11, 2021
0adfac6
Merge branch 'master' into get-port-stats-nil-pointer-deref
krsna1729 Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pfcpiface/bess.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ func (b *bess) getPortStats(ifname string) *pb.GetPortStatsResponse {
}

res, err := b.client.GetPortStats(ctx, req)
if err != nil || res.GetError() != nil {
log.Println("Error calling GetPortStats", ifname, err, res.GetError().Errmsg)
if err != nil {
pudelkoM marked this conversation as resolved.
Show resolved Hide resolved
log.Println("Error calling GetPortStats", ifname, err, res)
return nil
}

Expand Down