Run simulation mode as part of pfcp agent #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krsna1729
reviewed
Nov 30, 2021
Can you please extend pfcpsim in a follow-up PR to do multi-session testing like grpcsim. This will be helpful for performance benchmarking of PFCP layer |
I can certainly try. It would be really nice to have, I agree. |
pudelkoM
force-pushed
the
session-metrics-export
branch
from
4ed3f01
to
fa4a3eb
Compare
krsna1729
approved these changes
Dec 1, 2021
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have the spin up another pfcp agent instance to simulate session creation (
-simulate create) or deletion. As this runs in a completely separate process from the persistent agent, they do not share any state. This is problematic when other features, like flow measure, require data from inserted PDRs.Realistically, production setups should not be affected as all programming happens through PFCP messages, but for local testing this is a huge shortcoming. Especially since there is no equivalent simulator on the PFCP level available.
This change adds a new
-simulateflag value,create_continue, which runs the sim function as part of the agent startup procedure.