Export Prometheus flow metrics with UE IP labels #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krsna1729
reviewed
Dec 7, 2021
krsna1729
reviewed
Dec 7, 2021
pfcpiface/telemetry.go
Outdated
Comment on lines
101
to
105
| ch <- uc.sessionLatency | ||
| ch <- uc.sessionJitter | ||
| ch <- uc.sessionTxPackets | ||
| ch <- uc.sessionDroppedPackets | ||
| ch <- uc.sessionTxBytes |
There was a problem hiding this comment.
ideally we should have separate interface for these, like we have one for PFCP layer metrics.
Overall split could be -
- PFCP protocol metrics - interface - how many messages, sessions etc
- PFCP fastpath metrics - interface - fastpath performance of the session/pdr, can benefit from more PFCP context
- Fastpath backend specific metrics - need not be interface, registered/exported in their own files - fastpath wide latency. jitter, packets, bytes, dropped, memory util etc
There was a problem hiding this comment.
I tried to implement that approach by creating a new collector. Seems to fit much better, no duplicate state needed.
|
This pull request has been stale for 30 days and will be closed in 5 days. Comment to keep it open. |
pudelkoM
force-pushed
the
pfcp-prometheus-export-ue-ip
branch
from
f6e33bf
to
e93ee9c
Compare
pudelkoM
force-pushed
the
pfcp-prometheus-export-ue-ip
branch
2 times, most recently
from
ee04d04
to
d031507
Compare
pudelkoM
force-pushed
the
pfcp-prometheus-export-ue-ip
branch
from
d031507
to
52c6dec
Compare
osinstom
previously approved these changes
Jan 14, 2022
pudelkoM
force-pushed
the
pfcp-prometheus-export-ue-ip
branch
from
2c79d11
to
7cabef1
Compare
osinstom
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.