Allocate UE IPs based on SEID
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel IPpool should not be aware of pfcp details. We should be able to switch it out for a different IPAM implementation any time. Can we pass the session struct pointer to parsePDI and hold IP in session struct? This way it will allocate only if not set. |
|
retest this please |
ccascone
approved these changes
Dec 10, 2021
|
@krsna1729 this is blocking an imminent Aether 1.6 release, so I'm going to merge as-is. @pudelkoM is planning a follow-up PR to address your comment. BTW the hope is that we will stop rushing merges like this one as we add more testing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered a bug when using UE IP allocation and sending multiple PDRs for one session. The code allocated one UE IP per PDR, which leads to incorrect data plane programming and loss of connectivity for the UE.
This PR changes the IP allocation scheme from per-PDR to per-SEID. Only the first time we see a new session we allocate a new IP. Subsequent calls are satisfied with the same IP. On
SessionDeletionwe free the address.