Workaround for division by zero crash #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the author of this PR knows very little about C++, DPDK, and BESS... we ask reviewers to please be gentle :) |
ccascone
force-pushed
the
div-zero
branch
2 times, most recently
from
b826989
to
08135fd
Compare
|
this workaround has been running on 3 deployments for more than 24 hours, no crash has been reported since then. I'm planning to merge this soon, after I figure out why CI is failing. |
|
pls look at the comments given. |
|
@amarsri28 I replied to your comments on #376. It looks like you don't have any explicit concern with this PR, so I'm going ahead and merge this. |
thakurajayL
approved these changes
Dec 15, 2021
|
retest this please |
amarsri28
added a commit
to amarsri28/upf-epc
that referenced
this pull request
Feb 28, 2022
This reverts commit 103b198.
This was referenced Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't know yet the root cause of #376. The crash has been observed multiple times per day on a few production deployments. This is a workaround to prevent the crash while we investigate the root cause.
We don't know how to reproduce the issue, but we know it happens once in a while (tens of minutes to hours after starting bessd). As a consequence, we assume this workaround will be hit only a few times, causing only a few packets to skip the meter and be marked as green. We can better asses the frequency by looking at the new log message.