Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add infrastructure for integration tests #409

Merged
merged 20 commits into from Jan 18, 2022
Merged

Add infrastructure for integration tests #409

merged 20 commits into from Jan 18, 2022

Conversation

osinstom
Copy link
Contributor

@osinstom osinstom commented Jan 14, 2022 •
edited

This PR adds infrastructure for integration tests and implements a basic test that verifies the PFCP Association Setup procedure.

@osinstom osinstom self-assigned this Jan 14, 2022
@osinstom osinstom marked this pull request as ready for review January 16, 2022 14:46
@osinstom osinstom requested review from pudelkoM, EmanueleGallone and ccascone and removed request for EmanueleGallone January 16, 2022 14:47
@osinstom
Copy link
Contributor Author

cc: @krsna1729 @daniele-moro @EmanueleGallone

ccascone
ccascone previously approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@ccascone ccascone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I left only minor comments. I really like the simplicity of the approach (go tests and a bmv2-based fast-path). Thanks also for the detailed README.

.github/workflows/test-integration.yml Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
pkg/pfcpsim/pfcpsim.go Outdated Show resolved Hide resolved
pkg/pfcpsim/pfcpsim.go Outdated Show resolved Hide resolved
test/integration/README.md Outdated Show resolved Hide resolved
test/integration/README.md Outdated Show resolved Hide resolved
test/integration/infra/docker-compose.yml Outdated Show resolved Hide resolved
@osinstom @ccascone
Apply suggestions from code review
061bf63 
Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
@osinstom osinstom merged commit 1160e55 into omec-project:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniele-moro daniele-moro daniele-moro left review comments

@ccascone ccascone ccascone approved these changes

@pudelkoM pudelkoM Awaiting requested review from pudelkoM

Assignees

@osinstom osinstom

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@osinstom @ccascone @daniele-moro