Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for basic PFCP session establishment #411

Merged
merged 33 commits into from Jan 24, 2022

Conversation

osinstom
Copy link
Contributor

@osinstom osinstom commented Jan 18, 2022

This PR adds a basic PFCP session establishment test. It just verifies if the PFCP session has been established.

Verifying P4Runtime entries requires more work (i.e. modification of external Go P4Runtime library). I'll add P4Runtime verification in a subsequent PR.

@osinstom osinstom self-assigned this Jan 18, 2022
@osinstom osinstom marked this pull request as ready for review January 20, 2022 09:16
ccascone
ccascone previously approved these changes Jan 22, 2022
Copy link
Contributor

@ccascone ccascone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Can be merged after fixing the license check.

@@ -28,8 +120,36 @@ func TestBasicPFCPAssociation(t *testing.T) {
err := pfcpClient.SetupAssociation()
require.NoErrorf(t, err, "failed to setup PFCP association")

time.Sleep(time.Second*10)
time.Sleep(time.Second * 10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wait here for a few heartbeats and then check.

@osinstom osinstom merged commit 18fdd56 into omec-project:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants