New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for basic PFCP session establishment #411
Conversation
Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
…upf-epc into integration-test-infra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Can be merged after fixing the license check.
@@ -28,8 +120,36 @@ func TestBasicPFCPAssociation(t *testing.T) { | |||
err := pfcpClient.SetupAssociation() | |||
require.NoErrorf(t, err, "failed to setup PFCP association") | |||
|
|||
time.Sleep(time.Second*10) | |||
time.Sleep(time.Second * 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why so long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wait here for a few heartbeats and then check.
This PR adds a basic PFCP session establishment test. It just verifies if the PFCP session has been established.
Verifying P4Runtime entries requires more work (i.e. modification of external Go P4Runtime library). I'll add P4Runtime verification in a subsequent PR.