Implement read timeout for PFCP connection to detect a peer crash #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccascone
previously approved these changes
Jan 22, 2022
pfcpiface/conn.go
Outdated
| @@ -179,12 +179,26 @@ func (pConn *PFCPConn) setLocalNodeID(id string) { | |||
|
|
|||
| // Serve serves forever a single PFCP peer. | |||
| func (pConn *PFCPConn) Serve() { | |||
| go func() { | |||
| connClosed := make(chan struct{}, 1) | |||
There was a problem hiding this comment.
The name is misleading, it looks like a read timeout can happen even with a connection that is still open
Suggested change
| connClosed := make(chan struct{}, 1) | |
| connTimeout := make(chan struct{}, 1) |
Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
ccascone
previously approved these changes
Jan 22, 2022
|
retest this please |
added 2 commits
January 24, 2022 15:42
ccascone
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PFCP does not send any message in the
read_timeoutperiod, PFCP Agent closes the PFCP connection and clears the fastpath state.This behavior is needed to detect SMF crash (covered by
smf-failure.xmlSTC test).