Sync UP4 plugin with the latest pipeline #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @daniele-moro |
daniele-moro
approved these changes
Jan 26, 2022
| @@ -507,19 +510,28 @@ func (t *P4rtTranslator) buildUplinkTerminationsEntry(pdr pdr, shouldDrop bool, | |||
| return nil, err | |||
| } | |||
|
|
|||
| // FIXME: replace app_id with a meaningful value once we implement the full support for app filtering | |||
| if err := t.withExactMatchField(entry, FieldApplicationID, uint8(0)); err != nil { | |||
There was a problem hiding this comment.
uint8(0) define constant?
There was a problem hiding this comment.
Does it make sense? It's a temporary change and I will replace that soon.
There was a problem hiding this comment.
I believe that constant is used in #410 as the default behavior (here: https://github.com/omec-project/upf-epc/pull/410/files#diff-b2e5401707df74f20e19da386241442387f6ef81557463d84d849f7f9ebe6c45R692). Defining a constant helps as intrinsic documentation as well. Maybe just keep this comment valid for #410 and leave this as is.
There was a problem hiding this comment.
let's keep this comment valid for #410. This line will be changed in that PR.
ccascone
approved these changes
Jan 26, 2022
pudelkoM
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs UP4 plugin with the latest pipeline, but does not handle application filtering rules. UP4 termination tables are configured with "don't care" app_id.