Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -mod=vendor when building Docker image #427

Merged
merged 11 commits into from Feb 1, 2022
Merged

Use -mod=vendor when building Docker image #427

merged 11 commits into from Feb 1, 2022

Conversation

osinstom
Copy link
Contributor

@osinstom osinstom commented Jan 26, 2022

This is needed if we want to use local dependencies (for the development process). Otherwise, Docker build cannot find a local path. In particular, we need this change to allow testing changes to the following libraries: p4runtime-go-client and pfcpsim.

TODO:

  • add developer guide

@osinstom osinstom self-assigned this Jan 26, 2022
Copy link
Member

@pudelkoM pudelkoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, the great benefits of splitting everything up into many repos...

test/integration/README.md Outdated Show resolved Hide resolved
@osinstom osinstom merged commit 20124a2 into master Feb 1, 2022
@osinstom osinstom deleted the add-mod-vendor branch February 1, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants