Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test parsing of PDRs FARs and QERs #440

Merged
merged 12 commits into from Feb 8, 2022
Merged

Test parsing of PDRs FARs and QERs #440

merged 12 commits into from Feb 8, 2022

Conversation

EmanueleGallone
Copy link
Contributor

PR's aim is to test the parsing of session rules by adding several test cases.

osinstom
osinstom reviewed Feb 5, 2022
View reviewed changes
pfcpiface/parse-pdr_test.go Outdated Show resolved Hide resolved
pfcpiface/parse-pdr_test.go Outdated Show resolved Hide resolved
pfcpiface/parse-qer_test.go Outdated Show resolved Hide resolved
pfcpiface/parse-qer_test.go Outdated Show resolved Hide resolved
pfcpiface/parse-pdr_test.go Outdated Show resolved Hide resolved
osinstom
osinstom reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@osinstom osinstom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix conflicts and remove leftover, then we can merge

test/integration/ies.go Outdated Show resolved Hide resolved
@osinstom osinstom merged commit 2be3b93 into omec-project:master Feb 8, 2022
@EmanueleGallone EmanueleGallone deleted the add-tests branch February 14, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osinstom osinstom osinstom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EmanueleGallone @osinstom