Use a time-based P4RT election ID in tests #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
commented
Feb 4, 2022
pudelkoM
force-pushed
the
time-based-election-id
branch
from
0525bec
to
256023d
Compare
pudelkoM
force-pushed
the
time-based-election-id
branch
from
256023d
to
32cde67
Compare
osinstom
pushed a commit
that referenced
this pull request
Feb 8, 2022
osinstom
pushed a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows reconnects without having to manually increasing the ID.
I hit this issue when trying to re-run the integration tests against an existing instance.
See: https://github.com/pins/pins-infra/blob/master/p4_pdpi/p4_runtime_session.h#L52-L61