Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ParseIP function #463

Merged
merged 4 commits into from Feb 9, 2022
Merged

Refactor ParseIP function #463

merged 4 commits into from Feb 9, 2022

Conversation

pudelkoM
Copy link
Member

@pudelkoM pudelkoM commented Feb 8, 2022 •
edited

  • Move from main.go to utils
  • Add unit test
  • Rename to reflect behavior

osinstom
osinstom previously approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@osinstom osinstom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left two minor comments

pfcpiface/pfcpsim.go Outdated Show resolved Hide resolved
pfcpiface/utils.go Outdated Show resolved Hide resolved
osinstom
osinstom previously approved these changes Feb 9, 2022
View reviewed changes
osinstom
osinstom previously approved these changes Feb 9, 2022
View reviewed changes
@pudelkoM pudelkoM merged commit 3c00298 into master Feb 9, 2022
@pudelkoM pudelkoM deleted the refactor-parse-ip branch February 9, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osinstom osinstom osinstom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pudelkoM @osinstom