Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config parsing and validation into config.go #469

Merged
merged 15 commits into from Feb 10, 2022
Merged

Conversation

pudelkoM
Copy link
Member

@pudelkoM pudelkoM commented Feb 9, 2022

This change collects all the checks, parsers and validations littered around, and puts them in one place.
Defaults are now set in one place and at startup, so the full config can be logged and inspected.

pfcpiface/config.go Outdated Show resolved Hide resolved
pfcpiface/config.go Show resolved Hide resolved
pfcpiface/config.go Outdated Show resolved Hide resolved
pfcpiface/main.go Outdated Show resolved Hide resolved
osinstom
osinstom previously approved these changes Feb 10, 2022
@osinstom
Copy link
Contributor

It looks like JSON files for integration tests must be updated.

@osinstom
Copy link
Contributor

just one concern on moving ue_ip_pool and enable_ue_ip_alloc to the root level of the JSON file: are we worried about breaking existing deployments? We would need to update a lot of deployment files..

CC: @ccascone

@pudelkoM
Copy link
Member Author

just one concern on moving ue_ip_pool and enable_ue_ip_alloc to the root level of the JSON file: are we worried about breaking existing deployments? We would need to update a lot of deployment files..

Good point, I think we can skip on the move part. But ip pool should still be removed from p4rtciface, right?

@pudelkoM
Copy link
Member Author

I moved it back. Let's keep breakage here to a minimum, we can tackle that later.

@ccascone
Copy link
Contributor

We are already introducing a number of breaking changes with Aether 2.0 that will require reviewing config files for existing deployments. This is a good time to clean up the JSON schema.

Copy link
Contributor

@osinstom osinstom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but CI won't allow us to merge this with integration tests failing.

@osinstom osinstom merged commit 8f41cfb into master Feb 10, 2022
@osinstom osinstom deleted the move-config branch February 10, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants