New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move config parsing and validation into config.go
#469
Conversation
It looks like JSON files for integration tests must be updated. |
just one concern on moving CC: @ccascone |
Good point, I think we can skip on the move part. But ip pool should still be removed from |
I moved it back. Let's keep breakage here to a minimum, we can tackle that later. |
9353b17
to
73179a9
Compare
We are already introducing a number of breaking changes with Aether 2.0 that will require reviewing config files for existing deployments. This is a good time to clean up the JSON schema. |
73179a9
to
8f95aa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but CI won't allow us to merge this with integration tests failing.
This change collects all the checks, parsers and validations littered around, and puts them in one place.
Defaults are now set in one place and at startup, so the full config can be logged and inspected.