Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics/up4 bess #54

Merged
merged 7 commits into from Jul 18, 2020
Merged

Topics/up4 bess #54

merged 7 commits into from Jul 18, 2020

Conversation

ajamshed
Copy link
Contributor

Pipeline under construction.

[RFC] Check ExactMatch module. Validate the correctness of the changes. exactmatch.bess & exactmatch-val.bess scripts checked in for validation.

@ajamshed ajamshed requested a review from krsna1729 May 16, 2020 08:03
@ajamshed ajamshed force-pushed the topics/up4-bess branch 2 times, most recently from e0fdc5a to 783c5d7 Compare May 16, 2020 23:09
@krsna1729
Copy link
Member

we should probably make a copy of spgwu.bess -> upf.bess where we interate on the pipeline.

@ajamshed
Copy link
Contributor Author

we should probably make a copy of spgwu.bess -> upf.bess where we interate on the pipeline.

Done.

@ajamshed ajamshed force-pushed the topics/up4-bess branch 4 times, most recently from bfadf82 to 38ffd2d Compare May 19, 2020 01:56
@krsna1729
Copy link
Member

cleanup would be to move all the diff to exactmatch module. 0 diff in exactmatch table as much as possible.

@ajamshed ajamshed force-pushed the topics/up4-bess branch 2 times, most recently from fe18d35 to 75d0476 Compare May 19, 2020 18:58
core/modules/counter.cc Outdated Show resolved Hide resolved
core/modules/counter.h Outdated Show resolved Hide resolved
core/modules/counter.cc Outdated Show resolved Hide resolved
@ajamshed ajamshed force-pushed the topics/up4-bess branch 5 times, most recently from 2a98067 to 77d4c6c Compare May 23, 2020 09:24
conf/exactmatch-val.bess Outdated Show resolved Hide resolved
conf/exactmatch.bess Outdated Show resolved Hide resolved
conf/up4.bess Outdated Show resolved Hide resolved
conf/wildcardmatch.bess Outdated Show resolved Hide resolved
pfcpiface/pfcpiface.go Outdated Show resolved Hide resolved
pfcpiface/pfcpiface.go Outdated Show resolved Hide resolved
pfcpiface/pfcpiface.go Outdated Show resolved Hide resolved
@ajamshed ajamshed force-pushed the topics/up4-bess branch 2 times, most recently from badb81e to d72543c Compare July 10, 2020 02:59
@ajamshed ajamshed force-pushed the topics/up4-bess branch 2 times, most recently from b6d25f5 to 173eaf5 Compare July 11, 2020 00:48
@ajamshed ajamshed added wip and removed wip labels Jul 11, 2020
@ajamshed ajamshed force-pushed the topics/up4-bess branch 2 times, most recently from 5076596 to 568e5c3 Compare July 16, 2020 19:43
@yoooou
Copy link

yoooou commented Jul 17, 2020

retest this please

1 similar comment
@yoooou
Copy link

yoooou commented Jul 17, 2020

retest this please

@yoooou
Copy link

yoooou commented Jul 17, 2020

retest this please

ajamshed and others added 7 commits July 17, 2020 17:48
Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
Co-authored-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
Co-authored-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
Co-authored-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
Co-authored-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
Co-authored-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
Co-authored-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
Documentation updates.
Setup scripts.
GitHub workflow scripts.

Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
Co-authored-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@ajamshed ajamshed marked this pull request as ready for review July 18, 2020 02:20
@ajamshed ajamshed requested a review from krsna1729 July 18, 2020 02:21
Copy link
Member

@krsna1729 krsna1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoooou
Copy link

yoooou commented Jul 18, 2020

retest this please

@ajamshed ajamshed merged commit 330ac5e into master Jul 18, 2020
@krsna1729 krsna1729 deleted the topics/up4-bess branch July 26, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants