Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of Go proto files #575

Closed
wants to merge 2 commits into from
Closed

Fix generation of Go proto files #575

wants to merge 2 commits into from

Conversation

osinstom
Copy link
Contributor

Once we moved to Go 1.16 we observe the following issue when building Go protobuf files:

#15 0.398 go: go.mod file not found in current directory or any parent directory.
#15 0.398 	'go get' is no longer supported outside a module.
#15 0.398 	To build and install a command, use 'go install' with a version,
#15 0.398 	like 'go install example.com/cmd@latest'
#15 0.398 	For more information, see https://golang.org/doc/go-get-install-deprecation
#15 0.398 	or run 'go help get' or 'go help install'.

This PR fixes it by following https://grpc.io/docs/languages/go/quickstart/#regenerate-grpc-code.

@@ -5,3 +5,5 @@
*.pyc
*.swp
output

pfcpiface/bess_pb/github.com/omec-project/upf-epc/pfcpiface/bess_pb/service_grpc.pb.go
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is duplicated service_grpc.pb.go generated now, which is useless.

@osinstom osinstom mentioned this pull request Mar 17, 2022
@osinstom osinstom requested a review from pudelkoM March 17, 2022 15:46
@pudelkoM
Copy link
Member

#580 had the immediate fix, now we can work on improvements here.

@osinstom osinstom closed this Mar 18, 2022
@pudelkoM pudelkoM deleted the fix-proto-gen branch March 18, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants