Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BESS patches and directly modify ONF's BESS with these changes #647

Merged
merged 3 commits into from Nov 1, 2022

Conversation

gab-arrobo
Copy link
Collaborator

@gab-arrobo gab-arrobo commented Oct 28, 2022

The goal of this patch is to apply the BESS patches directly into the ONF's BESS fork instead of having them here and apply them during the Docker build process.

ONF's BESS PR 1 include the patches that were removed from here. So, the changes here go along with ONF's BESS PR 1. That is, I expect the Pull Request task/check to fail until ONF's BESS PR 1 is merged

@omecproject
Copy link

Can one of the admins verify this patch?

@amarsri28
Copy link
Contributor

@gab-arrobo just trying to understand benefit of this PR's . could you pls explain.

for me and other developers who complained about ( -security team team while developing sgx)-its being a big pain as i need to first file build bess for data plane changes, do corresponding changes in pfcp and then then fetch bess and do debugging in upf for every single patch. for small changes that might be ok but for big patches its a length process. lets discuss it

@gab-arrobo
Copy link
Collaborator Author

@gab-arrobo just trying to understand benefit of this PR's . could you pls explain.

for me and other developers who complained about ( -security team team while developing sgx)-its being a big pain as i need to first file build bess for data plane changes, do corresponding changes in pfcp and then then fetch bess and do debugging in upf for every single patch. for small changes that might be ok but for big patches its a length process. lets discuss it

@amarsri28, the goal of this PR is to try to simplify the whole development process. The first step is to apply the bess patches (patches/bess/*.patch) directly into the ONF's BESS repo. So, the process of applying these patches to create a new patch in BESS would not be needed anymore

@gab-arrobo gab-arrobo marked this pull request as ready for review November 1, 2022 23:27
@thakurajayL thakurajayL merged commit f3b21d5 into omec-project:master Nov 1, 2022
@gab-arrobo gab-arrobo deleted the remove-bess-patches branch November 2, 2022 17:04
@amarsri28
Copy link
Contributor

@gab-arrobo @thakurajayL this patch set has broken compilation of upf-epc - (reported by community member ). better keep upf repo up unless we prepare bess in background , its ok even though migration take time .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants