Initial integration of Cloud Native Data Plane with BESS OMEC-UPF #656

manojgop · 2022-12-08T06:11:54Z

Add support for Cloud Native Data Plane (CNDP) with BESS UPF pipeline.
Modify Dockerfile and scripts to add support of CNDP.
Example CNDP JSONC configuration files for single and multiple worker threads.
README file with instructions for setting up BESS UPF with CNDP.

Signed-off-by: Manoj Gopalakrishnan manoj.gopalakrishnan@intel.com

omecproject · 2022-12-08T06:11:56Z

Can one of the admins verify this patch?

manojgop · 2022-12-08T06:13:22Z

This PR should be merged after BESS PR omec-project/bess#2 is merged

manojgop · 2022-12-14T05:35:44Z

CI pipeline mentions there is no copyright and licensing information for image file in this PR. Do we need to add these details for image files. If so, how can we add that ?

The following files have no copyright and licensing information:
* docs/images/cndp-omec-upf-test-setup.jpg

gab-arrobo · 2022-12-26T16:32:27Z

CI pipeline mentions there is no copyright and licensing information for image file in this PR. Do we need to add these details for image files. If so, how can we add that ?
The following files have no copyright and licensing information:
* docs/images/cndp-omec-upf-test-setup.jpg

@amolonf @thakurajayL please your comments/feedback about this. Thanks!

gab-arrobo · 2023-01-14T02:24:50Z

CI pipeline mentions there is no copyright and licensing information for image file in this PR. Do we need to add these details for image files. If so, how can we add that ?
The following files have no copyright and licensing information:
* docs/images/cndp-omec-upf-test-setup.jpg
@amolonf @thakurajayL please your comments/feedback about this. Thanks!

Hi @amolonf @thakurajayL , any comments about this. Thanks!

amolonf · 2023-01-14T03:52:05Z

retest this please

gab-arrobo · 2023-01-14T04:05:11Z

@amolonf, the issue is that one of the checks related to the copyrights fails because an image (JPG file) does not have a copyright. Please see it here:

The following files have no copyright and licensing information:

docs/images/cndp-omec-upf-test-setup.jpg

amolonf · 2023-01-14T04:11:21Z

@amolonf, the issue is that one of the checks related to the copyrights fails because an image (JPG file) does not have a copyright. Please see it here:

The following files have no copyright and licensing information:

docs/images/cndp-omec-upf-test-setup.jpg

I did not see this kind of error. Can you please try with other format like svg?

gab-arrobo · 2023-01-14T04:32:58Z

@amolonf, the issue is that one of the checks related to the copyrights fails because an image (JPG file) does not have a copyright. Please see it here:

The following files have no copyright and licensing information:

docs/images/cndp-omec-upf-test-setup.jpg

I did not see this kind of error. Can you please try with other format like svg?

@manojgop, can you please try Amol's suggestion?

gab-arrobo · 2023-01-19T23:49:02Z

CI pipeline mentions there is no copyright and licensing information for image file in this PR. Do we need to add these details for image files. If so, how can we add that ?
The following files have no copyright and licensing information:
* docs/images/cndp-omec-upf-test-setup.jpg

@manojgop you can use reuse to do that. Here are the instructions: https://reuse.software/tutorial/#step-2

gab-arrobo

Need to address issue with copyright in one file

manojgop · 2023-01-21T06:58:06Z

Need to address issue with copyright in one file

Reuse tool created "cndp-omec-upf-test-setup.jpg.license" file with below content. It didn't modify the original jpg file. So should I include the file "cndp-omec-upf-test-setup.jpg.license" in PR

Copyright 2019 Intel Corporation

SPDX-License-Identifier: Apache-2.0

gab-arrobo · 2023-01-21T07:09:20Z

Yes, try doing that to see if it fixes the license issue.

pfcpiface/config.go

scripts/docker_setup.sh

conf/pktgen_cndp.bess

conf/upf.json

manojgop · 2023-01-30T03:51:07Z

@gab-arrobo Have updated PR incorporating review comments. Please review

gab-arrobo · 2023-01-30T05:12:46Z

@gab-arrobo Have updated PR incorporating review comments. Please review

Hi @manojgop, I will try to give it another review this week.

manojgop · 2023-02-13T16:14:18Z

@gab-arrobo Have updated PR incorporating review comments. Please review

Hi @manojgop, I will try to give it another review this week.

@gab-arrobo Did you get a chance to review

gab-arrobo · 2023-02-13T18:40:17Z

@gab-arrobo Have updated PR incorporating review comments. Please review

Hi @manojgop, I will try to give it another review this week.

@gab-arrobo Did you get a chance to review

@manojgop. I had not had time to review it again... I am going to try to give it another review this or next week. Sorry for the delay!

docs/CNDP_README.md

conf/cndp_upf_4worker.jsonc

conf/cndp_upf_1worker.jsonc

conf/cndp_upf_4worker.jsonc

conf/upf.json

scripts/docker_setup.sh

manojgop · 2023-04-18T06:43:52Z

Can anyone explain why there is a PMD option for xskdev API?

reference:

isn't this option only apply to pktdev API?

CNDP supports different poll mode drivers (PMD). For BESS UPF, CNDP uses AF-XDP PMD. More info in https://github.com/CloudNativeDataPlane/cndp/blob/main/doc/guides/pmds/overview.rst. And CNDP - BESS uses xskdev to use custom mempool management for AF-XDP UMEM

gab-arrobo · 2023-05-04T15:36:55Z

@badhrinathpa @thakurajayL @amarsri28 @sureshmarikkannu, I would appreciate your input about this PR

docs/CNDP_README.md

gab-arrobo · 2023-05-16T04:16:02Z

docs/CNDP_README.md

+### Step 1: Build the OMEC UPF docker container
+
+> Note: If you are behind a proxy make sure to export/setenv http_proxy and https_proxy
+
+From the top level directory call:
+
+```
+$ make docker-build
+```


Is this step really needed? make docker-build is already being called from docker_setup.sh

Building the image upfront will make script execution faster. I could remove it if you feel this additional step is not user friendly.

docs/CNDP_README.md

scripts/cndp_reset_upf.sh

docs/CNDP_README.md

gab-arrobo · 2023-05-23T22:36:49Z

@manojgop, BTW, is not there need to enable DDP?

docs/CNDP_README.md

- Add support for Cloud Native Data Plane (CNDP) with BESS UPF pipeline. - Modify Dockerfile and scripts to add support of CNDP. - Example CNDP JSONC configuration files for single and multiple worker threads. - README file with instructions for setting up BESS UPF with CNDP. Signed-off-by: Manoj Gopalakrishnan <manoj.gopalakrishnan@intel.com>

Signed-off-by: Manoj Gopalakrishnan <manoj.gopalakrishnan@intel.com>

scripts/docker_setup.sh

docs/CNDP_README.md

Signed-off-by: Manoj Gopalakrishnan <manoj.gopalakrishnan@intel.com>

docs/CNDP_README.md

gab-arrobo · 2023-06-07T23:38:20Z

@manojgop, everything seems to be working as expected. Please added the issue with the Speellcheck GHA and we will be done with this review. Thanks!

manojgop · 2023-06-08T04:08:13Z

@manojgop, everything seems to be working as expected. Please added the issue with the Speellcheck GHA and we will be done with this review. Thanks!

Updated PR

Signed-off-by: Manoj Gopalakrishnan <manoj.gopalakrishnan@intel.com>

gab-arrobo

+1

gab-arrobo · 2023-06-08T04:37:55Z

@thakurajayL, @badhrinathpa, @amarsri28, @sureshmarikkannu, I completed the review (including testing it with 1, 4 and 8 workers) and everything in PR looks good. So, I approved it. I am planning to merge it in a couple days. Please feel free to provide your input if possible. Thanks!

manojgop mentioned this pull request Dec 8, 2022

Add support for CNDP(Cloud Native Data Plane) port in BESS omec-project/bess#2

Merged

manojgop force-pushed the feat_cndp_upf_initial branch 2 times, most recently from 04716e2 to 2854309 Compare December 8, 2022 06:22

gab-arrobo requested review from gab-arrobo, amarsri28, badhrinathpa and thakurajayL January 14, 2023 02:25

gab-arrobo reviewed Jan 19, 2023

View reviewed changes

manojgop force-pushed the feat_cndp_upf_initial branch from 6c3e98c to e7cbe3e Compare January 21, 2023 07:15

gab-arrobo reviewed Jan 22, 2023

View reviewed changes

manojgop force-pushed the feat_cndp_upf_initial branch from e7cbe3e to bb85aea Compare January 23, 2023 04:08

gab-arrobo reviewed Mar 13, 2023

View reviewed changes

manojgop force-pushed the feat_cndp_upf_initial branch 2 times, most recently from 4b02396 to bd725d2 Compare March 14, 2023 10:41

manojgop force-pushed the feat_cndp_upf_initial branch from 4e7a509 to afb143e Compare April 18, 2023 06:25

manojgop force-pushed the feat_cndp_upf_initial branch 2 times, most recently from 4a178f8 to 05492e2 Compare April 18, 2023 16:10

gab-arrobo reviewed May 16, 2023

View reviewed changes

gab-arrobo reviewed May 17, 2023

View reviewed changes

docs/CNDP_README.md Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

gab-arrobo reviewed May 23, 2023

View reviewed changes

docs/CNDP_README.md Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

gab-arrobo reviewed May 23, 2023

View reviewed changes

scripts/cndp_reset_upf.sh Outdated Show resolved Hide resolved

scripts/cndp_reset_upf.sh Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

manojgop force-pushed the feat_cndp_upf_initial branch from 69e2a97 to c584e9e Compare May 24, 2023 13:43

gab-arrobo reviewed May 24, 2023

View reviewed changes

docs/CNDP_README.md Show resolved Hide resolved

manojgop force-pushed the feat_cndp_upf_initial branch 3 times, most recently from e889d22 to 863f3c5 Compare May 30, 2023 12:29

manojgop added 2 commits May 30, 2023 12:38

Address review comments.

8c31dea

Signed-off-by: Manoj Gopalakrishnan <manoj.gopalakrishnan@intel.com>

gab-arrobo reviewed May 31, 2023

View reviewed changes

scripts/docker_setup.sh Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

Address review comments: 2.

739f9a9

Signed-off-by: Manoj Gopalakrishnan <manoj.gopalakrishnan@intel.com>

manojgop force-pushed the feat_cndp_upf_initial branch from 863f3c5 to 739f9a9 Compare June 6, 2023 15:43

gab-arrobo reviewed Jun 6, 2023

View reviewed changes

docs/CNDP_README.md Outdated Show resolved Hide resolved

docs/CNDP_README.md Outdated Show resolved Hide resolved

manojgop force-pushed the feat_cndp_upf_initial branch from 082db7d to c47cb4b Compare June 8, 2023 04:07

Address review comments: 3.

c47cb4b

Signed-off-by: Manoj Gopalakrishnan <manoj.gopalakrishnan@intel.com>

gab-arrobo approved these changes Jun 8, 2023

View reviewed changes

gab-arrobo merged commit 4181480 into omec-project:master Jun 12, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial integration of Cloud Native Data Plane with BESS OMEC-UPF #656

Initial integration of Cloud Native Data Plane with BESS OMEC-UPF #656

manojgop commented Dec 8, 2022

omecproject commented Dec 8, 2022

manojgop commented Dec 8, 2022

manojgop commented Dec 14, 2022

gab-arrobo commented Dec 26, 2022

gab-arrobo commented Jan 14, 2023

amolonf commented Jan 14, 2023

gab-arrobo commented Jan 14, 2023

amolonf commented Jan 14, 2023

gab-arrobo commented Jan 14, 2023

gab-arrobo commented Jan 19, 2023

gab-arrobo left a comment

manojgop commented Jan 21, 2023

gab-arrobo commented Jan 21, 2023 via email •

edited

manojgop commented Jan 30, 2023

gab-arrobo commented Jan 30, 2023

manojgop commented Feb 13, 2023

gab-arrobo commented Feb 13, 2023

manojgop commented Apr 18, 2023 •

edited

gab-arrobo commented May 4, 2023

gab-arrobo May 16, 2023

manojgop May 24, 2023

gab-arrobo commented May 23, 2023

gab-arrobo commented Jun 7, 2023

manojgop commented Jun 8, 2023

gab-arrobo left a comment

gab-arrobo commented Jun 8, 2023

Initial integration of Cloud Native Data Plane with BESS OMEC-UPF #656

Initial integration of Cloud Native Data Plane with BESS OMEC-UPF #656

Conversation

manojgop commented Dec 8, 2022

omecproject commented Dec 8, 2022

manojgop commented Dec 8, 2022

manojgop commented Dec 14, 2022

gab-arrobo commented Dec 26, 2022

gab-arrobo commented Jan 14, 2023

amolonf commented Jan 14, 2023

gab-arrobo commented Jan 14, 2023

amolonf commented Jan 14, 2023

gab-arrobo commented Jan 14, 2023

gab-arrobo commented Jan 19, 2023

gab-arrobo left a comment

Choose a reason for hiding this comment

manojgop commented Jan 21, 2023

gab-arrobo commented Jan 21, 2023 via email • edited

manojgop commented Jan 30, 2023

gab-arrobo commented Jan 30, 2023

manojgop commented Feb 13, 2023

gab-arrobo commented Feb 13, 2023

manojgop commented Apr 18, 2023 • edited

gab-arrobo commented May 4, 2023

gab-arrobo May 16, 2023

Choose a reason for hiding this comment

manojgop May 24, 2023

Choose a reason for hiding this comment

gab-arrobo commented May 23, 2023

gab-arrobo commented Jun 7, 2023

manojgop commented Jun 8, 2023

gab-arrobo left a comment

Choose a reason for hiding this comment

gab-arrobo commented Jun 8, 2023

gab-arrobo commented Jan 21, 2023 via email •

edited

manojgop commented Apr 18, 2023 •

edited