Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable go lint CI in all directories #759

Merged
merged 5 commits into from Feb 7, 2024

Conversation

patriciareinoso
Copy link
Contributor

Add go vet configuration to CI
Enable go vet analyzers except for fieldalignment
Disable CI linters that fail
Fixes govet shadow, goimports, gofmt, unparam and inefassign linters

Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
@omecproject
Copy link

Can one of the admins verify this patch?

Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
@patriciareinoso patriciareinoso changed the title Enable go lint CI Enable go lint CI in all directories Feb 6, 2024
patriciareinoso and others added 2 commits February 6, 2024 17:31
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Copy link
Collaborator

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run an E2E test to verify everything works as expected?

cmd/p4info_code_gen/p4info_code_gen.go Show resolved Hide resolved
test/integration/providers/docker.go Outdated Show resolved Hide resolved
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Copy link
Collaborator

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (tested changes under 2 different setups: 1) as part of AiaB; and 2) With the UPF in stand-alone mode using traffic generator)

@gab-arrobo gab-arrobo merged commit 0855b55 into omec-project:master Feb 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants